Re: [RFC PATCH v1 1/2] chnet: Prepare global struct ch_thpool array

[Ammar Nofan Faizi <ammar_nofan_faizi@yahoo.com>]

On 8/29/22 11:21 AM, Alviro Iskandar Setiawan wrote:
> On Mon, Aug 29, 2022 at 8:11 AM Ammar Faizi wrote:
>> +       g_max_ch_thpool = std::thread::hardware_concurrency() - 1;
>> +       if (g_max_ch_thpool < 1)
>> +               g_max_ch_thpool = 1;
> 
> this is wrong, std::thread::hardware_concurrency() should be treated
> as a hint, if this happens to return 0, then the sub with 1 will make
> it ~0, that will definitely hit ENOMEM.
> 
> this should be:
> 
>          g_max_ch_thpool = std::thread::hardware_concurrency();
>          if (g_max_ch_thpool <= 1)
>                  g_max_ch_thpool = 1;
>          else
>                  g_max_ch_thpool -= 1;

Ah yes, you're right. Will fix it in the v2.

-- 
Ammar Faizi