Re: [PATCH v3 5/9] atom: add manage_payload()

[Ammar Faizi <ammarfaizi2@gnuweeb.org>]

On 10/21/22 9:02 PM, Muhammad Rizki wrote:
> On 21/10/2022 21.01, Ammar Faizi wrote:
>> On 10/21/22 8:45 PM, Muhammad Rizki wrote:
>>> +def manage_payload(payload: Message):
>>> +    p = str(payload.get_payload())
>>> +    tf_encode = payload.get("Content-Transfer-Encoding")
>>> +
>>> +    if tf_encode == "base64":
>>> +        return b64decode(p).decode("utf-8")
>>> +    if tf_encode == "quoted-printable":
>>> +        return quopri.decodestring(p.encode()).decode()
>>> +
>>> +    return p.encode().decode("utf-8", errors="replace")
>>
>> I don't feel strongly about this helper name. What about name it
>> with get_decoded_paylaod()?
>>
> 
> Sure, or just decode_payload()?

Since you pass a Message object and it contains headers and body,
I prefer to emphasize the "get". So I still prefer the name
get_decoded_paylaod() for this function. What we call payload is
the body anyway.

-- 
Ammar Faizi