Re: [PATCH v1 2/2] daemon: telegram: Handle MySQL error

[Muhammad Rizki <kiizuha@gnuweeb.org>]

On 29/10/22 02.08, Alviro Iskandar Setiawan wrote:
>
>> Here is my improved remove_patch():
>>
>>
>>       def remove_patch(
>>          tmp: Union[str, list] = None,
>>          platform: Platform = Platform.TELEGRAM
>>       ):
>>              if isinstance(tmp, str):
>>                      return shutil.rmtree(tmp)
>>
>>               # check if the tmp is None or an empty list or empty str
>>               # if they are empty or None then remove using glob UNIX
>>               # style path which is if empty will not throw an error
>>              if not bool(tmp):
>>                      platform = platform.TELEGRAM.value
>>                      store_dir = os.getenv("STORAGE_DIR", "storage")
>>                      for d in glob.glob(f"{platform}/{store_dir}/*/"):
>>                              shutil.rmtree(d)
>>                      return
> 
> This is insane. That listener is running asynchronously, and you
> delete all temporary files without holding any mutex. At that time,
> another async job *may still be using* the files you batch-delete in
> this code.

Sorry, you mention remove_patch() which function from? Telegram bot 
listener __send_mail() ? if yes, that function is already handled by 
mutex, see it on telegram/mailer/listener.py of __handle_mail(), in line 
77 it is already hold.