Re: [PATCH server-a001 v2 4/4] Create start.sh to start the docker container

[Ammar Faizi <ammarfaizi2@gnuweeb.org>]

On 5/1/22 7:15 PM, Hazmi Alfarizqi wrote:
> On 01/05/2022 00:08, Ammar Faizi wrote:
>> Create a file named start.sh. This is a script to start the container
>> with prepared configuration. Only run this script on the host.
>>
>> Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
> 
> It seems that `server-a001` gonna be the image name? I would assume we
> will build the Docker image from Dockerfile directly on the host.

Yes for both sentences.

> If not and the image will be pulled from some registry, the image name
> format would look like: [registry/]Username/Image[:tag] (Example:
> docker.io/username/image:latest).
> 
> The tag is optional, the default tag would be latest.
> For the registry part, if it's docker.io (which is the default
> registry for Docker) it will be omitted on Docker, but not on Podman.

We don't intend to push this image.

What kind of changes do you recommend?
Keep it like this or add the "latest" tag?

-- 
Ammar Faizi