public inbox for [email protected]
 help / color / mirror / Atom feed
From: Pavel Begunkov <[email protected]>
To: Ammar Faizi <[email protected]>
Cc: Jens Axboe <[email protected]>,
	io-uring Mailing List <[email protected]>
Subject: Re: [PATCH liburing 2/3] examples: add a simple single-shot poll benchmark
Date: Tue, 14 Jun 2022 16:05:16 +0100	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 6/14/22 15:57, Ammar Faizi wrote:
> On 6/14/22 9:36 PM, Pavel Begunkov wrote:
>> +int main(void)
>> +{
>> +    unsigned long tstop;
>> +    unsigned long nr_reqs = 0;
>> +    struct io_uring_cqe *cqe;
>> +    struct io_uring_sqe *sqe;
>> +    struct io_uring ring;
>> +    int pipe1[2];
>> +    int ret, i, qd = 128;
>> +
>> +    if (argc > 1)
>> +        return 0;
>> +
> 
> Hi Pavel,
> 
> I am testing this and it doesn't compile, the main(void) needs fixing.

Indeed, some of final changes escaped git add. Thanks Ammar

> 
> ```
>    poll-bench.c: In function ‘main’:
>    poll-bench.c:39:13: error: ‘argc’ undeclared (first use in this function)
>       39 |         if (argc > 1)
>          |             ^~~~
>    poll-bench.c:39:13: note: each undeclared identifier is reported only once for each function it appears in
>    make[1]: *** [Makefile:34: poll-bench] Error 1
>    make[1]: *** Waiting for unfinished jobs....
>    make[1]: Leaving directory '/home/ammarfaizi2/app/liburing/examples'
>    make: *** [Makefile:12: all] Error 2
> ```
> 

-- 
Pavel Begunkov


  reply	other threads:[~2022-06-14 15:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-14 14:36 [PATCH liburing 0/3] single-issuer and poll benchmark Pavel Begunkov
2022-06-14 14:36 ` [PATCH liburing 1/3] io_uring: update headers with IORING_SETUP_SINGLE_ISSUER Pavel Begunkov
2022-06-14 14:36 ` [PATCH liburing 2/3] examples: add a simple single-shot poll benchmark Pavel Begunkov
2022-06-14 14:57   ` Ammar Faizi
2022-06-14 15:05     ` Pavel Begunkov [this message]
2022-06-14 14:36 ` [PATCH liburing 3/3] tests: test IORING_SETUP_SINGLE_ISSUER Pavel Begunkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox