Re: [PATCH liburing 5/5] overflow: add tests

[Dylan Yudaken <dylany@fb.com>]

On Thu, 2022-04-21 at 18:44 +0700, Ammar Faizi wrote:
> On 4/21/22 4:14 PM, Dylan Yudaken wrote:
> > Add tests that verify that overflow conditions behave
> > appropriately.
> > Specifically:
> >   * if overflow is continually flushed, then CQEs should arrive
> > mostly in
> >   order to prevent starvation of some completions
> >   * if CQEs are dropped due to GFP_ATOMIC allocation failures it is
> >   possible to terminate cleanly. This is not tested by default as
> > it
> >   requires debug kernel config, and also has system-wide effects
> > 
> > Signed-off-by: Dylan Yudaken <dylany@fb.com>
> > ---
> 
> Dylan, this breaks -Werror build with clang-15.
> 
> ```
>    cq-overflow.c:188:15: error: variable 'drop_count' set but not
> used [-Werror,-Wunused-but-set-variable]
>            unsigned int drop_count = 0;
>                         ^
>    1 error generated.
>    make[1]: *** [Makefile:210: cq-overflow.t] Error 1
>    make[1]: *** Waiting for unfinished jobs....
> ```
> 
> Maybe you miss something that you forgot to use the value of
> @drop_count?
> 

Ah - I had some debug statements that were using it but did not remove
it when removing those (the versions of gcc/clang I have do not
complain). I will clean it up in v2.
Thanks for spotting it!