From: Ammar Faizi <[email protected]>
To: Muhammad Rizki <[email protected]>,
Alviro Iskandar Setiawan <[email protected]>
Cc: GNU/Weeb Mailing List <[email protected]>
Subject: Re: [PATCH v1 2/2] daemon: telegram: Handle MySQL error
Date: Sat, 29 Oct 2022 02:16:49 +0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 10/29/22 1:52 AM, Muhammad Rizki wrote:
> def remove_patch(
> tmp: Union[str, list] = None,
> platform: Platform = Platform.TELEGRAM
> ):
> if isinstance(tmp, str):
> return shutil.rmtree(tmp)
>
> # check if the tmp is None or an empty list or empty str
isinstance("", str) is True, so this won't be reached if you pass an
empty string. It'll early return at "if isinstance("", str)".
I think it's the caller responsibility not to pass an invalid file
name. If the caller passes an invalid @tmp value, then you code it
wrong.
--
Ammar Faizi
next prev parent reply other threads:[~2022-10-28 19:16 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 15:08 [PATCH v1 0/2] Automatic recovery from a MySQL restart Ammar Faizi
2022-10-27 15:08 ` [PATCH v1 1/2] daemon: telegram: db: Allow the caller to reconnect Ammar Faizi
2022-10-27 16:52 ` Muhammad Rizki
2022-10-27 16:54 ` Muhammad Rizki
2022-10-28 5:48 ` Ammar Faizi
2022-10-27 15:08 ` [PATCH v1 2/2] daemon: telegram: Handle MySQL error Ammar Faizi
2022-10-28 9:21 ` Alviro Iskandar Setiawan
2022-10-28 9:28 ` Ammar Faizi
2022-10-28 9:24 ` Alviro Iskandar Setiawan
2022-10-28 9:32 ` Ammar Faizi
2022-10-28 9:40 ` Alviro Iskandar Setiawan
2022-10-28 9:43 ` Ammar Faizi
2022-10-28 16:29 ` Ammar Faizi
2022-10-28 16:46 ` Alviro Iskandar Setiawan
2022-10-28 16:54 ` Ammar Faizi
2022-10-28 18:10 ` Muhammad Rizki
2022-10-28 18:26 ` Alviro Iskandar Setiawan
2022-10-28 18:52 ` Muhammad Rizki
2022-10-28 19:08 ` Alviro Iskandar Setiawan
2022-10-28 19:15 ` Muhammad Rizki
2022-10-28 19:29 ` Alviro Iskandar Setiawan
2022-10-28 19:34 ` Ammar Faizi
2022-10-28 19:36 ` Ammar Faizi
2022-10-28 19:38 ` Ammar Faizi
2022-10-28 19:44 ` Muhammad Rizki
2022-10-28 19:39 ` Muhammad Rizki
2022-10-28 19:44 ` Alviro Iskandar Setiawan
2022-10-28 19:46 ` Muhammad Rizki
2022-10-28 19:53 ` Alviro Iskandar Setiawan
2022-10-28 19:16 ` Ammar Faizi [this message]
2022-10-28 19:19 ` Muhammad Rizki
2022-10-28 19:19 ` Ammar Faizi
2022-10-28 19:22 ` Muhammad Rizki
2022-10-28 19:33 ` Ammar Faizi
2022-10-28 19:38 ` Muhammad Rizki
2022-10-28 17:02 ` Muhammad Rizki
2022-10-28 17:19 ` Ammar Faizi
2022-10-28 18:15 ` Muhammad Rizki
2022-10-28 18:18 ` Muhammad Rizki
2022-10-28 19:49 ` Ammar Faizi
2022-10-28 19:55 ` Muhammad Rizki
2022-10-28 19:46 ` Ammar Faizi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox