From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ammarfaizi2@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,NO_DNS_FOR_FROM,
	URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
Received: from [10.7.7.2] (unknown [182.253.183.90])
	by gnuweeb.org (Postfix) with ESMTPSA id 98FB580BE8;
	Fri, 28 Oct 2022 19:16:52 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=default; t=1666984613;
	bh=Lzzpk6cURXNaZE+EuWscAZe/w9sZGSXrD4qoAolRO4o=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=jyX6z0IH6BS8SImHOkgZvaohKdJ7dsu7fLIbIhW2y+vHDJM19y93lTOdI7lFLs0E6
	 IrcXprc3J8S/xFQ7GS9ZJJrs0kuB6o3BbS9zZL47R15vqMV8tMOFGk5l2jzoWXBUl+
	 FnNqJ8leUm3Vo3ofDV3H3rjDLQ/LzZDx+QLmuNzhWSiJnFxuN07AtjU/aMaXnFY5Q+
	 riA1qhhTpe8a6GsnCaY4FvG8Y6nxkSuIumEC6ShDXuuvdyRBHhMJu0vqBUaA1sPaKg
	 lEg+7J+u2vgQ694qDIaZlSmt+/u7Y77+XRUv3KcQcBu3ZXZc+TaoXEbiJMt7WxjW9Q
	 CFvXEKlma5Prg==
Message-ID: <59d21a5e-8ade-f9fe-b2e5-1bea79b07921@gnuweeb.org>
Date: Sat, 29 Oct 2022 02:16:49 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v1 2/2] daemon: telegram: Handle MySQL error
Content-Language: en-US
To: Muhammad Rizki <kiizuha@gnuweeb.org>,
 Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
Cc: GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
References: <20221027150823.601914-1-ammarfaizi2@gnuweeb.org>
 <20221027150823.601914-3-ammarfaizi2@gnuweeb.org>
 <CAOG64qN9BZcnz1px8tAj9_Y96FhU1nVMOA58rfs-4nRY6GhWAg@mail.gmail.com>
 <1d500d37-b11b-75fd-38e5-d7f8e0a9b1d4@gnuweeb.org>
 <CAOG64qO8c4gE=HmL-1QQkqenD+T4ezsU=+FCGsth59=CFjyKpw@mail.gmail.com>
 <3a79a587-ddee-9e25-2ac5-b573938b44a9@gnuweeb.org>
 <043f55c3-67d8-9130-aca4-73c59926d2af@gnuweeb.org>
 <CAOG64qNSS6S0geOHHi50Z_sW5ymW4Cb5=JYt5VO3=4-jjh2KhQ@mail.gmail.com>
 <63aa1b63-f7e2-8da3-b16d-0c7e1045d697@gnuweeb.org>
 <CAOG64qOoL3knPRTVcX+jOopt+24vE0C39Y0Jf1-YAnbGhG7LFQ@mail.gmail.com>
 <9ecfe8ab-fa5a-d01a-0b68-bc639f14888f@gnuweeb.org>
From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
In-Reply-To: <9ecfe8ab-fa5a-d01a-0b68-bc639f14888f@gnuweeb.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
List-Id: <gwml.vger.gnuweeb.org>

On 10/29/22 1:52 AM, Muhammad Rizki wrote:
>      def remove_patch(
>      tmp: Union[str, list] = None,
>      platform: Platform = Platform.TELEGRAM
>      ):
>          if isinstance(tmp, str):
>              return shutil.rmtree(tmp)
> 
>              # check if the tmp is None or an empty list or empty str

isinstance("", str) is True, so this won't be reached if you pass an
empty string. It'll early return at "if isinstance("", str)".

I think it's the caller responsibility not to pass an invalid file
name. If the caller passes an invalid @tmp value, then you code it
wrong.

-- 
Ammar Faizi