From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from mail-il1-f170.google.com (mail-il1-f170.google.com [209.85.166.170]) by gnuweeb.org (Postfix) with ESMTPS id 91B1D7E3A7 for ; Fri, 29 Apr 2022 18:22:00 +0000 (UTC) Authentication-Results: gnuweeb.org; dkim=pass (2048-bit key; unprotected) header.d=kernel-dk.20210112.gappssmtp.com header.i=@kernel-dk.20210112.gappssmtp.com header.a=rsa-sha256 header.s=20210112 header.b=gbjFB6+b; dkim-atps=neutral Received: by mail-il1-f170.google.com with SMTP id r17so4505102iln.9 for ; Fri, 29 Apr 2022 11:22:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=boBqcZUUd3lpbXllOKgvkHZhlPyPffKAlzYRl9LXtpk=; b=gbjFB6+bQSryclVz014EuajmCHeeQwOC+fRF88W6on/Qkgft0NhjneEfdDSiENJJJd sFYRmc+tqshkFUX2jsmrzsWNksa8HKPbFkoePVCTnfgDuenfx9fgkI4KHXyDYeP7XS6C JaQz9ACpgAJ5xl8GNBtL8FMuXkzZUwTYAjJJVl6MNX59oX10BnNFKNhxEJGl65js4GdN AJDU4W/GrYbQ/8y4azb3qaeSRpelgWTRztBQBvnp25IZsFj6w4Uzvm4Scay9c98gq1pX aIgtE16hHGpR16mgmG1oVeigMzdQiKjYYl05spAar9AOBUHy1lUQjbOFMWoF0PQsqDTm 8mIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=boBqcZUUd3lpbXllOKgvkHZhlPyPffKAlzYRl9LXtpk=; b=SfgWQNRTZAMFr2S0jkRNZF9LkXs5i+2x+7PqI05ZkC7oaECM4dukayQTe9Ds2Ki2yp nJ2Q/I1FbyFcZBjEDXXVTHcaDdt9PJn9X5DwPHtYTck/NAzTY8P9LaDM7/qmS8FWFoNj RWTT93y1tqhY6FXRnRMM6x5YuZzmYYI1diRQdNnyLWK6aQtBuQ7RPN+l1bE1Y1/6BUq6 BPu+FHO2Xzb7llL/i/pEuUJVgqaMfoRHOyWU1Oa/5p49MoOUfcP1BRNoryTa3nEIDCuT qeIUq0ltKtT4FsrlHGAdhyeayPaWty8KvOvtAfw2qjynHcJcDYULl8lNeFVS7081ItSZ qXcA== X-Gm-Message-State: AOAM531OJWNrtUpjSQMm5e0nnULHT3C6vWcYJt6AOJYkPSUlcgim45/H WR7kRVE/ram8+rNl/0MV0cOiTA== X-Google-Smtp-Source: ABdhPJy0hAazhU3cgDv3j2yfHLn7RPQyzvfqgHW5knMrNjpG7bnSys1jk7v8mjPYaPWvwRPwh5l3nA== X-Received: by 2002:a05:6e02:16cf:b0:2cc:3986:264a with SMTP id 15-20020a056e0216cf00b002cc3986264amr267599ilx.8.1651256519542; Fri, 29 Apr 2022 11:21:59 -0700 (PDT) Received: from [192.168.1.172] ([207.135.234.126]) by smtp.gmail.com with ESMTPSA id z7-20020a926507000000b002cde6e352e5sm703036ilb.47.2022.04.29.11.21.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Apr 2022 11:21:59 -0700 (PDT) Message-ID: <5a686d0d-63e8-33c5-d59b-dad1bceaae4c@kernel.dk> Date: Fri, 29 Apr 2022 12:21:58 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v1 0/8] fio error handling fixes Content-Language: en-US To: Ammar Faizi Cc: Alviro Iskandar Setiawan , Niklas Cassel , fio Mailing List , GNU/Weeb Mailing List References: <20220429004705.260034-1-ammarfaizi2@gnuweeb.org> From: Jens Axboe In-Reply-To: <20220429004705.260034-1-ammarfaizi2@gnuweeb.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: On 4/28/22 6:46 PM, Ammar Faizi wrote: > From: Ammar Faizi > > Hi Jens, > > This series contains patches that were dropped from my previous thread: > > https://lore.kernel.org/fio/20220428203954.222165-1-ammarfaizi2@gnuweeb.org > > Plus, I have more patches in this series. This series contains error > handling fixes, mostly about ENOMEM. There are 8 patches in this > series. All of them are ENOMEM handling stuff except that patch #4 has > extra fixes and a bit of refactoring. While I agree on good error handling in general, I'm a bit dubious at malloc() related NULL returns. Have you ever seen malloc() return NULL? On Linux, or somewhere else? Most systems overcommit themselves to death, and things will death spiral before you ever get NULL. I'm happy to be convinced otherwise, just naturally skeptical that there's any real value in making changes like this. -- Jens Axboe