From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,NO_DNS_FOR_FROM, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from [10.7.7.14] (unknown [182.253.88.229]) by gnuweeb.org (Postfix) with ESMTPSA id 8C0A4804D1; Mon, 7 Nov 2022 01:31:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1667784669; bh=LJfdrtaHnE6kC36kuwE+SXTuDyKWkMbKPnmF2kohypI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=YX5UXzwJBCH282/XB6Pu/Qn4gpNCDC/9MXIAQye0W846mCGIGBXwnj0+kiFcmhKsV SQZzQou2bxR75vvszm0RuslWuSR59pz/BzyLdEeBxNsQnV5w2mQF16at761Ga7oZ/6 DjdU5Oa60+/k30jGYz6LDv1cZg1fbzD4WSGBLQF6dEq1CLQHmkom/7y9gO+fIXnR/8 IO01byCD5xdy2kHrEIWWX7zK+rHSRWLzXBKmF6vDL4qBoyMHd/Mhi1mtvZ6XWwCF/0 zcEXPbpSq3m+f8nB6BiZBO35T+ZETmrr2LbhEBUllBSDEFVQpERdbJDfH5J+3Kz0RQ HPy/nWLnJqmCQ== Message-ID: <5ab12c59-d8f3-efbe-38c9-0ff92e398741@gnuweeb.org> Date: Mon, 7 Nov 2022 08:31:06 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v1 11/16] telegram: Implement the log message for catching errors Content-Language: en-US To: Muhammad Rizki Cc: Alviro Iskandar Setiawan , GNU/Weeb Mailing List References: <20221104180931.3852-1-kiizuha@gnuweeb.org> <20221104180931.3852-15-kiizuha@gnuweeb.org> <8ce63732-0cdb-e3b0-f292-5433e5b35ff1@gnuweeb.org> <9bce4733-0133-adf9-6291-3a932df80973@gnuweeb.org> <5151f6a6-f87d-1c7f-3333-26adb5223e32@gnuweeb.org> <6d954bf9-096f-626d-2465-43512323277f@gnuweeb.org> From: Ammar Faizi In-Reply-To: <6d954bf9-096f-626d-2465-43512323277f@gnuweeb.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: On 11/7/22 8:26 AM, Muhammad Rizki wrote: > IDK the rule about changelog in commit desc must have relevant with the > "current "series". I mean, I don't understand why did you write this: v4: - Add logger v3: - Simplify try and except statement (comment from Muhammad Rizki). v2: * no changes * What is v4? What is v3? What is v2? When did the revision happen? It makes *zero* sense to have v2 to v4 changelog in v1 patch. -- Ammar Faizi