From: Jens Axboe <[email protected]>
To: Dylan Yudaken <[email protected]>, [email protected]
Cc: [email protected], [email protected]
Subject: Re: [PATCH 1/3] io_uring: add io_uring_get_opcode
Date: Mon, 25 Apr 2022 06:38:37 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 4/25/22 3:36 AM, Dylan Yudaken wrote:
> + return "UNKNOWN";
> +}
My only worry here is that it's another place to touch when adding an
opcode. I'm assuming the compiler doesn't warn if you're missing one
since it's not strongly typed?
In any case, the LAST one is just a sentinel, both that and beyond
should return eg INVALID.
--
Jens Axboe
next prev parent reply other threads:[~2022-04-25 12:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 9:36 [PATCH 0/3] text representation of opcode in trace Dylan Yudaken
2022-04-25 9:36 ` [PATCH 1/3] io_uring: add io_uring_get_opcode Dylan Yudaken
2022-04-25 12:38 ` Jens Axboe [this message]
2022-04-25 9:36 ` [PATCH 2/3] io_uring: rename op -> opcode Dylan Yudaken
2022-04-25 9:36 ` [PATCH 3/3] io_uring: use the text representation of ops in trace Dylan Yudaken
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox