From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no autolearn_force=no version=3.4.6 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 770B5C433F5 for ; Mon, 25 Apr 2022 12:38:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236780AbiDYMlr (ORCPT ); Mon, 25 Apr 2022 08:41:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239300AbiDYMlo (ORCPT ); Mon, 25 Apr 2022 08:41:44 -0400 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48040B1AAC for ; Mon, 25 Apr 2022 05:38:39 -0700 (PDT) Received: by mail-pl1-x632.google.com with SMTP id q8so3556456plx.3 for ; Mon, 25 Apr 2022 05:38:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=h0N7Xw9ayMdjNwT+dSboLXsyap22Y+266R7Xi2cibFs=; b=61PV7TT9x9f2J91ymKhTAJROmDBdiSnye7cS97bFeFx0tnP5BXAq022YG7YU7EOkUS ATRWyhxtuN/PB98vOXniHDwoEbBcib7Yp8Rj7/khDwA+4lRccTZFoSA9QEAJvv6DJxtb uYePq8Sny77H+B1cV52bKymyPEeMg9JJpt7fKHTYaRk9XLwSbWTcL7Ezv4lC3W8mQr/r 9odzAkJrVJAirgJF3feTFpPZkT20O8XtOAOfCPaOBjazzISiIUa95+t9nFMoiDy0bA4z xc5ooOezfu1vhDZ9xY1qdVQspfrRHVCrtgpj0oaKY4T3CtHT9ePntdk92jmyugnu39vo Zz/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=h0N7Xw9ayMdjNwT+dSboLXsyap22Y+266R7Xi2cibFs=; b=boKdgAB1mtRbOQDAqfFvpmAwZSZqTkJBUV4BlzfCTxW/jcLkhS+X8uYORs8uzFRFy6 h+p8MZcR+jnL5qKyWRMFlPszaGTkfiLv49FcfFtz+4REvv9MGX4FBGsjTSWICgUKDMzo PsIGTl9oQDPepVLM/abU8QBJeGguTPTjFNKpx6ILKQuzfRPvhFJlEofFdwTUNeDhth7o OYmcl7BFeK+vcl7tYgKkGt6PW5xWJSnLzjMcCLLhwqPV+3/REjCqVMcyRXvdX7k700OZ 59JRIAdO10AdEEZHosrFbt35Bxz5y2/AokjKr9xZy4vbqjPeKTU792y3zPVAH7du9iZq wbBw== X-Gm-Message-State: AOAM531WE6SclvAeVXurLqtZqC2OE7m20aWt8hOrP9x/bWsQgr6K8efv DVOdRNG0XVyghPNHRqjzuA2MCA== X-Google-Smtp-Source: ABdhPJzblpd/s3fALv+p83Q+7D6atxbr9Isq/TnwnxkM0Yt41RJhTmNAu9I+aeXEkt9NqwqGBfV0tQ== X-Received: by 2002:a17:902:e494:b0:15a:4b81:1c16 with SMTP id i20-20020a170902e49400b0015a4b811c16mr18158054ple.10.1650890318954; Mon, 25 Apr 2022 05:38:38 -0700 (PDT) Received: from [192.168.1.100] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id 64-20020a17090a0fc600b001d5f22845bdsm14878023pjz.1.2022.04.25.05.38.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Apr 2022 05:38:38 -0700 (PDT) Message-ID: <5e09c3ea-8d72-5984-8c9e-9eec14567393@kernel.dk> Date: Mon, 25 Apr 2022 06:38:37 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 1/3] io_uring: add io_uring_get_opcode Content-Language: en-US To: Dylan Yudaken , io-uring@vger.kernel.org Cc: asml.silence@gmail.com, Kernel-team@fb.com References: <20220425093613.669493-1-dylany@fb.com> <20220425093613.669493-2-dylany@fb.com> From: Jens Axboe In-Reply-To: <20220425093613.669493-2-dylany@fb.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 4/25/22 3:36 AM, Dylan Yudaken wrote: > + return "UNKNOWN"; > +} My only worry here is that it's another place to touch when adding an opcode. I'm assuming the compiler doesn't warn if you're missing one since it's not strongly typed? In any case, the LAST one is just a sentinel, both that and beyond should return eg INVALID. -- Jens Axboe