Re: [PATCH liburing v1 2/2] test/Makefile: Append `.test` to the test binary filename

[Jens Axboe <axboe@kernel.dk>]

On 4/3/22 3:56 AM, Ammar Faizi wrote:
> When adding a new test, we often forget to add the new test binary to
> `.gitignore`. Append `.test` to the test binary filename, this way we
> can use a wildcard matching "test/*.test" in `.gitignore` to ignore all
> test binary files.

Did you build it?

     CC 917257daa0fe-test.test
/usr/bin/ld: /tmp/ccGrhiuN.o: in function `thread_start':
/home/axboe/git/liburing/test/35fa71a030ca-test.c:52: undefined reference to `pthread_attr_setstacksize'
/usr/bin/ld: /home/axboe/git/liburing/test/35fa71a030ca-test.c:55: undefined reference to `pthread_create'
     CC a0908ae19763-test.test
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:210: 35fa71a030ca-test.test] Error 1
make[1]: *** Waiting for unfinished jobs....
/usr/bin/ld: /tmp/cc2nozDW.o: in function `main':
/home/axboe/git/liburing/test/232c93d07b74-test.c:295: undefined reference to `pthread_create'
/usr/bin/ld: /home/axboe/git/liburing/test/232c93d07b74-test.c:296: undefined reference to `pthread_create'
/usr/bin/ld: /home/axboe/git/liburing/test/232c93d07b74-test.c:297: undefined reference to `pthread_join'
/usr/bin/ld: /home/axboe/git/liburing/test/232c93d07b74-test.c:298: undefined reference to `pthread_join'
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:210: 232c93d07b74-test.test] Error 1
make[1]: Leaving directory '/home/axboe/git/liburing/test'

I do like the idea of not having to keep fixing that gitignore list.

-- 
Jens Axboe