From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by gnuweeb.org (Postfix) with ESMTPS id 3E1117E330 for ; Sun, 3 Apr 2022 14:51:54 +0000 (UTC) Authentication-Results: gnuweeb.org; dkim=pass (2048-bit key; unprotected) header.d=kernel-dk.20210112.gappssmtp.com header.i=@kernel-dk.20210112.gappssmtp.com header.a=rsa-sha256 header.s=20210112 header.b=DT6vw3t5; dkim-atps=neutral Received: by mail-pl1-f171.google.com with SMTP id i11so6198991plg.12 for ; Sun, 03 Apr 2022 07:51:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=+eNrmaDd/ZDbML51HSAC8jpfHoQtdW5LvniIsFkdR84=; b=DT6vw3t5Qxro7EBw76r8K/aIQP3uWWpH4cK1sI0FhH33NnzJieFKzraxpf1ZanWb/Z 6jdCOIWV3rRTOtCTMoBxIKTtK788PG/lQfllkHb0o49qzg8RoNZ12S0AZpqPR9pmdeih 8Vd9NLSW1Vz21hIt8pmzaah1CvZil6CswPqLhG646VBBVeKIy4yXnRR3MSgBfWdBC8Xe ujmraW5nUec19Ht0aAyTiJNfbaJfYF7QyOK/I+aiWMmKtz397DlFGoAtuD9nuI5Q072d uyzFgLowhk37i+j6kRrTn/ZtIPSSTY8Tt0P6I+nHurSvLVjvFFAI+i4OCVSIFjFOyCex C6aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=+eNrmaDd/ZDbML51HSAC8jpfHoQtdW5LvniIsFkdR84=; b=3xeA/xWHzMPM9AGvmHWRtwJxz8GcdSxqrMpWVhXYY7nCYaLWN5tqb4AONmB6yM3uZP fjeYlURZ0NkJitCClDyvs4dJIpfPkdmQuGFA27zxz4DxhYUbzljikBNOwytZjoKDfGBC 5fX1K+bXVdhS2n0N9zEsQaus8pK2ZB2mF/6IUyldnDaqcBS5FyUm6xWYLn2AjsEAWWQq NlJm3gZu1zchK2KKKDavyOaHW9k5B8BLHyuMTi1tT+x8SliRpQHMQHCrxXETfhZ55Xlo bYl2xOkDURQZV2YfCQuJrRLCIFKzHmw/OxA7pmZhXJgFsndQSFm4U5udjzO0hWo1eBax kLTA== X-Gm-Message-State: AOAM533cAwCYYvZkqkcTS1+4TKFLQCSEIYAd15/hYhvKe9xAi/Tp4Apr D6dMavI/LWkQsDsC2ff5/u6QLw== X-Google-Smtp-Source: ABdhPJzMfc84gE/RaFZc/OixEpChXWOnTcipeOp7QHDp1VmasELupTjLI1W8dpIhl6VAOHEfb8JXtA== X-Received: by 2002:a17:90a:8b8b:b0:1ca:6007:36e5 with SMTP id z11-20020a17090a8b8b00b001ca600736e5mr7305679pjn.128.1648997513527; Sun, 03 Apr 2022 07:51:53 -0700 (PDT) Received: from [192.168.1.100] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id m21-20020a17090ab79500b001ca3c46ba2fsm7266415pjr.24.2022.04.03.07.51.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 03 Apr 2022 07:51:52 -0700 (PDT) Message-ID: <5eb7b378-b0cf-83ff-7796-87a33517b1a0@kernel.dk> Date: Sun, 3 Apr 2022 08:51:51 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH liburing v1 2/2] test/Makefile: Append `.test` to the test binary filename Content-Language: en-US To: Ammar Faizi Cc: io-uring Mailing List , GNU/Weeb Mailing List References: <20220403095602.133862-1-ammarfaizi2@gnuweeb.org> <20220403095602.133862-3-ammarfaizi2@gnuweeb.org> From: Jens Axboe In-Reply-To: <20220403095602.133862-3-ammarfaizi2@gnuweeb.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: On 4/3/22 3:56 AM, Ammar Faizi wrote: > When adding a new test, we often forget to add the new test binary to > `.gitignore`. Append `.test` to the test binary filename, this way we > can use a wildcard matching "test/*.test" in `.gitignore` to ignore all > test binary files. Did you build it? CC 917257daa0fe-test.test /usr/bin/ld: /tmp/ccGrhiuN.o: in function `thread_start': /home/axboe/git/liburing/test/35fa71a030ca-test.c:52: undefined reference to `pthread_attr_setstacksize' /usr/bin/ld: /home/axboe/git/liburing/test/35fa71a030ca-test.c:55: undefined reference to `pthread_create' CC a0908ae19763-test.test collect2: error: ld returned 1 exit status make[1]: *** [Makefile:210: 35fa71a030ca-test.test] Error 1 make[1]: *** Waiting for unfinished jobs.... /usr/bin/ld: /tmp/cc2nozDW.o: in function `main': /home/axboe/git/liburing/test/232c93d07b74-test.c:295: undefined reference to `pthread_create' /usr/bin/ld: /home/axboe/git/liburing/test/232c93d07b74-test.c:296: undefined reference to `pthread_create' /usr/bin/ld: /home/axboe/git/liburing/test/232c93d07b74-test.c:297: undefined reference to `pthread_join' /usr/bin/ld: /home/axboe/git/liburing/test/232c93d07b74-test.c:298: undefined reference to `pthread_join' collect2: error: ld returned 1 exit status make[1]: *** [Makefile:210: 232c93d07b74-test.test] Error 1 make[1]: Leaving directory '/home/axboe/git/liburing/test' I do like the idea of not having to keep fixing that gitignore list. -- Jens Axboe