From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ammarfaizi2@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,NO_DNS_FOR_FROM,
	URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
Received: from [192.168.88.87] (unknown [125.160.109.228])
	by gnuweeb.org (Postfix) with ESMTPSA id B4C9D80BE8;
	Wed, 16 Nov 2022 06:34:59 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=default; t=1668580501;
	bh=RTkIMOtf0HhfVfKBcaoF8pGYhOmFJpcuCVB8H/b0kAQ=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=A3gCFSFUVGNXHikFZY0Nkb3SgaZBlFoNnHwCBzgj5HiJOgBnRsjGkeDHg4l3mTnJx
	 YSuUW9OORLf+bUDg5/OJRf/Hid97VLux2HmdO4mcGW/QEcRKaL7bnmkdXCa9EvkBpX
	 TFDA2LNYI+t7Sydl1jT3o8uVDb95Oa40agzZrlvASyJLVpExmOqQPG4lSIGuWcdRPV
	 sKaZiSYLuV20v9MSfJwetdzZRN/vZX6JDZ1oiSRUzmdO87P2riLvGy9x2Ee3Hx1QOZ
	 pheBJK1xoFdSbvYNADGt+1MVLlig0ofBqipTr2JRyYyd/Qvg+OqGS0xMgFWZedE+ol
	 16UGA4axift+w==
Message-ID: <61293423-8541-cb8b-32b4-9a4decb3544f@gnuweeb.org>
Date: Wed, 16 Nov 2022 13:34:57 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: (subset) [PATCH v1 0/2] io_uring uapi updates
To: Jens Axboe <axboe@kernel.dk>
Cc: GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>,
 io-uring Mailing List <io-uring@vger.kernel.org>,
 Pavel Begunkov <asml.silence@gmail.com>, Stefan Metzmacher
 <metze@samba.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <20221115212614.1308132-1-ammar.faizi@intel.com>
 <166855408973.7702.1716032255757220554.b4-ty@kernel.dk>
Content-Language: en-US
From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
In-Reply-To: <166855408973.7702.1716032255757220554.b4-ty@kernel.dk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: <gwml.vger.gnuweeb.org>

On 11/16/22 6:14 AM, Jens Axboe wrote:
> On Wed, 16 Nov 2022 04:29:51 +0700, Ammar Faizi wrote:
>> From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
>>
>> Hi Jens,
>>
>> io_uring uapi updates:
>>
>> 1) Don't force linux/time_types.h for userspace. Linux's io_uring.h is
>>     synced 1:1 into liburing's io_uring.h. liburing has a configure
>>     check to detect the need for linux/time_types.h (Stefan).
>>
>> [...]
> 
> Applied, thanks!
> 
> [1/2] io_uring: uapi: Don't force linux/time_types.h for userspace
>        commit: 958bfdd734b6074ba88ee3abc69d0053e26b7b9c

Jens, please drop this commit. It breaks the build:

All errors (new ones prefixed by >>):

    In file included from <command-line>:
>> ./usr/include/linux/io_uring.h:654:41: error: field 'timeout' has incomplete type
      654 |         struct __kernel_timespec        timeout;
          |                                         ^~~~~~~

-- 
Ammar Faizi