From: Ammar Faizi <[email protected]>
To: Alviro Iskandar Setiawan <[email protected]>,
Jens Axboe <[email protected]>
Cc: Pavel Begunkov <[email protected]>,
Alviro Iskandar Setiawan <[email protected]>,
io-uring <[email protected]>, gwml <[email protected]>
Subject: Re: [PATCH liburing v2 2/4] src/Makefile: Add header files as dependency
Date: Thu, 10 Mar 2022 17:50:41 +0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 3/10/22 5:32 PM, Alviro Iskandar Setiawan wrote:
> When the header files are modified, the compiled objects are not going
> to be recompiled because the header files are not marked as a dependency
> for the objects.
>
> - Instruct the compiler to generate dependency files.
>
> - Include those files from src/Makefile. Ensure if any changes are
> made, files that depend on the changes are recompiled.
>
> Suggested-by: Ammar Faizi <[email protected]>
> Signed-off-by: Alviro Iskandar Setiawan <[email protected]>
You should add the dependency files to .gitignore, otherwise we will have
these files untracked after build.
Untracked files:
(use "git add <file>..." to include in what will be committed)
src/queue.ol.d
src/queue.os.d
src/register.ol.d
src/register.os.d
src/setup.ol.d
src/setup.os.d
src/syscall.ol.d
src/syscall.os.d
Also, when doing `make clean`, the dependency files should be removed.
--
Ammar Faizi
next prev parent reply other threads:[~2022-03-10 10:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 10:32 [PATCH liburing v2 0/4] Changes for Makefile Alviro Iskandar Setiawan
2022-03-10 10:32 ` [PATCH liburing v2 1/4] src/Makefile: Remove `-fomit-frame-pointer` from default build Alviro Iskandar Setiawan
2022-03-10 10:32 ` [PATCH liburing v2 2/4] src/Makefile: Add header files as dependency Alviro Iskandar Setiawan
2022-03-10 10:50 ` Ammar Faizi [this message]
2022-03-10 10:56 ` Alviro Iskandar Setiawan
2022-03-10 10:32 ` [PATCH liburing v2 3/4] test/Makefile: Add liburing.a as a dependency Alviro Iskandar Setiawan
2022-03-10 10:32 ` [PATCH liburing v2 4/4] examples/Makefile: " Alviro Iskandar Setiawan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox