GNU/Weeb Mailing List <[email protected]>
 help / color / mirror / Atom feed
From: Ammar Faizi <[email protected]>
To: Muhammad Rizki <[email protected]>
Cc: Alviro Iskandar Setiawan <[email protected]>,
	GNU/Weeb Mailing List <[email protected]>
Subject: Re: [PATCH v4 00/17] Fix, improvement and implement a bot logger.
Date: Sun, 25 Dec 2022 18:16:21 +0700	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

I don't like the directory naming here. This is confusing:

On 12/21/22 8:33 AM, Muhammad Rizki wrote:
>   daemon/atom/utils.py                          | 67 ++++++++++++++-----
>   daemon/dc.py                                  | 10 ++-
>   daemon/dscord/config.py.example               |  4 ++
>   daemon/dscord/gnuweeb/client.py               | 20 ++++--
>   daemon/dscord/gnuweeb/filters.py              | 10 ++-

For example, this one is named "gnuweeb". What does that exactly mean?
What is the directory supposed to contain?

>   .../dscord/gnuweeb/plugins/events/on_ready.py |  2 +-
>   .../plugins/slash_commands/get_lore_mail.py   | 12 ++--
>   daemon/dscord/mailer/listener.py              | 41 +++++++-----
>   daemon/logger/__init__.py                     |  1 +
>   daemon/logger/log.py                          | 52 ++++++++++++++
>   daemon/telegram/config.py.example             |  4 ++
>   daemon/telegram/mailer/listener.py            | 44 +++++++-----

Also we have "mailer" here. We don't have any mailer here.
I'm going to change the directory naming shortly.

-- 
Ammar Faizi


  parent reply	other threads:[~2022-12-25 11:16 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-21  1:33 [PATCH v4 00/17] Fix, improvement and implement a bot logger Muhammad Rizki
2022-12-21  1:33 ` [PATCH v4 01/17] discord: Fix typo on _flood_exception() Muhammad Rizki
2022-12-21  1:33 ` [PATCH v4 02/17] fix: utils: Fix .patch file payload Muhammad Rizki
2022-12-21  1:33 ` [PATCH v4 03/17] fix: utils: add a substr for the patch media caption Muhammad Rizki
2022-12-21  1:33 ` [PATCH v4 04/17] fix: utils: Fix the extract_list() utility function Muhammad Rizki
2022-12-21  1:33 ` [PATCH v4 05/17] utils: Back to use decode=True for the get_payload() Muhammad Rizki
2022-12-21  1:33 ` [PATCH v4 06/17] utils: Improve fix_utf8_char() Muhammad Rizki
2022-12-21  1:33 ` [PATCH v4 07/17] utils: Add catch_err() for the log message Muhammad Rizki
2022-12-21  1:33 ` [PATCH v4 08/17] logger: Initial work for the bot logger for future use Muhammad Rizki
2022-12-21  1:33 ` [PATCH v4 09/17] telegram: Use the created BotLogger() class Muhammad Rizki
2022-12-21  1:33 ` [PATCH v4 10/17] telegram: Add variable LOG_CHANNEL_ID declaration Muhammad Rizki
2022-12-21  1:33 ` [PATCH v4 11/17] telegram: Add send_log_file() in the DaemonClient() Muhammad Rizki
2022-12-21  1:33 ` [PATCH v4 12/17] telegram: Implement the log message for catching errors Muhammad Rizki
2022-12-24 21:22   ` Ammar Faizi
2022-12-24 21:39     ` Ammar Faizi
2022-12-21  1:33 ` [PATCH v4 13/17] discord: Add variable LOG_CHANNEL_ID declaration Muhammad Rizki
2022-12-21  1:33 ` [PATCH v4 14/17] discord: Use the BotLogger() to the GWClient() Muhammad Rizki
2022-12-21  1:33 ` [PATCH v4 15/17] discord: Add send_log_file in " Muhammad Rizki
2022-12-21  1:33 ` [PATCH v4 16/17] discord: Implement the catch erros and logs Muhammad Rizki
2022-12-21  1:33 ` [PATCH v4 17/17] Remove some unused imports Muhammad Rizki
2022-12-24 20:54 ` [PATCH v4 00/17] Fix, improvement and implement a bot logger Ammar Faizi
2022-12-24 21:05 ` Ammar Faizi
2022-12-24 21:09   ` Ammar Faizi
2022-12-24 23:31     ` Muhammad Rizki
2022-12-24 23:33       ` Ammar Faizi
2022-12-24 23:37         ` Muhammad Rizki
2022-12-24 23:34       ` Muhammad Rizki
2022-12-24 23:35         ` Ammar Faizi
2022-12-24 23:36           ` Ammar Faizi
2022-12-24 23:39             ` Muhammad Rizki
2022-12-25 11:16 ` Ammar Faizi [this message]
2022-12-25 11:29   ` Alviro Iskandar Setiawan
2022-12-25 11:34     ` Ammar Faizi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox