From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ammarfaizi2@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,NO_DNS_FOR_FROM,
	URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
Received: from [10.7.7.5] (unknown [182.253.183.184])
	by gnuweeb.org (Postfix) with ESMTPSA id 504CE7E292;
	Sun, 25 Dec 2022 11:16:25 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=default; t=1671966986;
	bh=rmDeBlKhOB9ca+Y2vqtAQ8FS2R1rtQawsqVbF2jmr4Y=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=b2W7jv1MAncz7t3Gbgg9tO2vd3fvo+lovbS6LWccIfvl2fI4e1BG0AiaEzCEbwQtz
	 UTwayKWswVbzIqytVXNga2dyUrRt3xXhz79hgbxICH+Qsp0os3Lyqoa/lvAqkkMftn
	 nh6tm88AjhZYzEx87rgGrgvIbK8lY1vPj1zr66jJ4CGO9hQOIZ2aWzQVyGegbbyd3t
	 OgYiJNPelnRp47HrrZzMIChZa+Rh6NSOgGeJL3oM7EO8EXzje43F2zmE5FXvZq9Eod
	 05e5QiP6DqMXPPn4RdNKgppGdU6mabQfx0KSp878jeqidl5VLRP+5VCsbO+tleeo6s
	 aMYxm/OSuKvjg==
Message-ID: <62f3e7d6-24ea-d5c7-2944-9a7b5fc1bf43@gnuweeb.org>
Date: Sun, 25 Dec 2022 18:16:21 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v4 00/17] Fix, improvement and implement a bot logger.
To: Muhammad Rizki <kiizuha@gnuweeb.org>
Cc: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
 GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
References: <20221221013347.1704-1-kiizuha@gnuweeb.org>
Content-Language: en-US
From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
In-Reply-To: <20221221013347.1704-1-kiizuha@gnuweeb.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: <gwml.vger.gnuweeb.org>

I don't like the directory naming here. This is confusing:

On 12/21/22 8:33 AM, Muhammad Rizki wrote:
>   daemon/atom/utils.py                          | 67 ++++++++++++++-----
>   daemon/dc.py                                  | 10 ++-
>   daemon/dscord/config.py.example               |  4 ++
>   daemon/dscord/gnuweeb/client.py               | 20 ++++--
>   daemon/dscord/gnuweeb/filters.py              | 10 ++-

For example, this one is named "gnuweeb". What does that exactly mean?
What is the directory supposed to contain?

>   .../dscord/gnuweeb/plugins/events/on_ready.py |  2 +-
>   .../plugins/slash_commands/get_lore_mail.py   | 12 ++--
>   daemon/dscord/mailer/listener.py              | 41 +++++++-----
>   daemon/logger/__init__.py                     |  1 +
>   daemon/logger/log.py                          | 52 ++++++++++++++
>   daemon/telegram/config.py.example             |  4 ++
>   daemon/telegram/mailer/listener.py            | 44 +++++++-----

Also we have "mailer" here. We don't have any mailer here.
I'm going to change the directory naming shortly.

-- 
Ammar Faizi