From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kiizuha@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,NO_DNS_FOR_FROM,
	URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
Received: from [192.168.1.2] (unknown [101.128.126.183])
	by gnuweeb.org (Postfix) with ESMTPSA id 82BB9804FD;
	Fri, 28 Oct 2022 18:10:52 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=default; t=1666980654;
	bh=hEvN99HjaWYjbrSIpwWqOBE0ZUIFFvcXTawCyHRd7HA=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=oIh1Jrfrtic7abSHrapdyuYNZZHwk+hf5GdnGI6tIdiMoirGnJDjn2LN4fOZoYVzI
	 2Ua346Mu5fV4By3nYRkfg3SW7pm2nJKKAmMrwk7emRcsevYGJ9T5ySmxuE06fle0x4
	 Iz89zcNuq3grAJCF6wHUEa/AQW1zx7Y4awCSfXYghT8uXqKNZUXvnVzpSkoeGMkEhk
	 KzShUpM+tvYv6Qyc+j6atH9SQ58ERAQJfKEXdZmxfJMgUsg0buN9vNEMNQOZuEopJu
	 kqcH8rYXhuP6dczCEx3VYrRzEkYRmVuQoEbQnxL/dOCsPkchndgJNl4Gl1PDz05Ard
	 Tz5k9Ur/uf8ZA==
Message-ID: <63aa1b63-f7e2-8da3-b16d-0c7e1045d697@gnuweeb.org>
Date: Sat, 29 Oct 2022 01:10:48 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v1 2/2] daemon: telegram: Handle MySQL error
To: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
 Ammar Faizi <ammarfaizi2@gnuweeb.org>
Cc: GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
References: <20221027150823.601914-1-ammarfaizi2@gnuweeb.org>
 <20221027150823.601914-3-ammarfaizi2@gnuweeb.org>
 <CAOG64qN9BZcnz1px8tAj9_Y96FhU1nVMOA58rfs-4nRY6GhWAg@mail.gmail.com>
 <1d500d37-b11b-75fd-38e5-d7f8e0a9b1d4@gnuweeb.org>
 <CAOG64qO8c4gE=HmL-1QQkqenD+T4ezsU=+FCGsth59=CFjyKpw@mail.gmail.com>
 <3a79a587-ddee-9e25-2ac5-b573938b44a9@gnuweeb.org>
 <043f55c3-67d8-9130-aca4-73c59926d2af@gnuweeb.org>
 <CAOG64qNSS6S0geOHHi50Z_sW5ymW4Cb5=JYt5VO3=4-jjh2KhQ@mail.gmail.com>
Content-Language: en-US
From: Muhammad Rizki <kiizuha@gnuweeb.org>
In-Reply-To: <CAOG64qNSS6S0geOHHi50Z_sW5ymW4Cb5=JYt5VO3=4-jjh2KhQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: <gwml.vger.gnuweeb.org>

On 28/10/22 23.46, Alviro Iskandar Setiawan wrote:
> Even this part is also problematic, if you hit an error before
> utils.remove_patch(), the patch file won't get removed because
> exception will stop the current execution and throw the exception to
> the previous call stack.

You are right. So we just check every value from the DB method and if 
it's None just return like goto?

> 
> I hate try and catch style, because it's very easy to miss an error
> like this. I prefer the way C handles error manually via return value
> like:
> 
>          ret = func_call();
>          if (ret < 0)
>                  goto clean_up;
> 

I've improved the remove_patch() earlier using the glob UNIX style path 
to check if all temp dirs is exists then remove them all. What do you think?