Re: [PATCH v2 2/2] daemon: telegram: Handle MySQL error

[Ammar Faizi <ammarfaizi2@gnuweeb.org>]

On 10/30/22 4:49 PM, Muhammad Rizki wrote:
> On 30/10/22 12.49, Ammar Faizi wrote:

I didn't write that. Don't change the quotation anyway.

>> +from mysql.connector.errors import OperationalError, DatabaseError
>> +
>> +
>>       async def __run(self):
>>           print("[__run]: Running...")
>> -        for url in self.db.get_atom_urls():
>> -            try:
>> +        try:
>> +            for url in self.db.get_atom_urls():
>>                   await self.__handle_atom_url(url)
>> -            except:
>> -                print(traceback.format_exc())
>> +        except (OperationalError, DatabaseError) as e:
>> +            await self.handle_db_error(e)
> 
> I prefer to do it like this way. What do you think?

Looks fine to me, will send a v3 with your changes applied.

Thanks.

-- 
Ammar Faizi