From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by gnuweeb.org (Postfix) with ESMTPS id 2507D8164B for ; Thu, 24 Nov 2022 13:27:32 +0000 (UTC) Authentication-Results: gnuweeb.org; dkim=pass (2048-bit key; unprotected) header.d=kernel-dk.20210112.gappssmtp.com header.i=@kernel-dk.20210112.gappssmtp.com header.a=rsa-sha256 header.s=20210112 header.b=ygwjtPLk; dkim-atps=neutral Received: by mail-pl1-f170.google.com with SMTP id j12so1470266plj.5 for ; Thu, 24 Nov 2022 05:27:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6PUjkejs+nls1t0g8306qXKrK0t8sq0eiojWBp1T41k=; b=ygwjtPLkzl+RyY/tk3SD4LOBlJUDjJnwGvA8ADxDdx138iq9g9xHwOimu7NGC8wczQ +Nh7QsgWnkfvaf6F12mOXbx0NoIKOmtU/5LV5IHADEWQ7vL1yz69987iL/sQsMUE1ZXm tDNXfDAqDhtAmIzF1Wm8oDBqqp2fRSKpVqhtizA3bjryXHl9JQIkSTl6Ebt0zCyP0CbF 1humz6LK/mFefZKTqkGOIMOlqy2P54dIIJypDkMn5MzdPWtHvUoXNev/y6BdD6WiNndx GCmi6Y/GL86qcLkq4QqDvIB4BHnkndG4QXyLH/nKIsNBX8xt6wOJ/tJQISYVvGsUNd8i 1NFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6PUjkejs+nls1t0g8306qXKrK0t8sq0eiojWBp1T41k=; b=jq2yElJFMlRsllW04KdHbfQwNtVElC9YaRmDcKdVaqtnXSBiPfOBRgSnRicgXJgpuB gOUNEkrW16gC5keEu1zDjG3TJ7mSMEF7nw/lP/WBRGzfePzAkgNYHe2ivcE0umrxNgdp ROK/e/Pn13u7C4gM1gTw6LUNuMwuaZKjI3NSpJZWQ86BDuafnSqW0eOtMnyF71p43rFd FgVKTAM4FtDkKhsBllKnF+wVuLQHQ79vHnrzlqmKPA9cnWWWemMeuiKR8i7MtS0UVQLG I/2Ajvvv6cq/ZEGkbSzPPsPIeMwKsUtnSOrN2MQHWa0wXZu08nT4IoCg5wpq4r4+vznm BsNA== X-Gm-Message-State: ANoB5plMycBTVW+pj7i/8C2Po3btlh+v6Fi6LDhKWXBVcjGdOtwPKItZ p88dnt2BiF0BEMTnQtb2MjvH8w== X-Google-Smtp-Source: AA0mqf53lyI6J898djDryaNUL6PElJapvl4Kf9JYydoaSogpRMuJ8FYENAEMKZQB4XYCVvASJIM1FQ== X-Received: by 2002:a17:903:26ce:b0:187:31da:a27e with SMTP id jg14-20020a17090326ce00b0018731daa27emr13389502plb.111.1669296451473; Thu, 24 Nov 2022 05:27:31 -0800 (PST) Received: from [192.168.4.201] (cpe-72-132-29-68.dc.res.rr.com. [72.132.29.68]) by smtp.gmail.com with ESMTPSA id v3-20020a170902e8c300b00186c3afb49esm1251774plg.209.2022.11.24.05.27.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Nov 2022 05:27:30 -0800 (PST) Message-ID: <6491d7b5-0a52-e6d1-0f86-d36ec88bbc15@kernel.dk> Date: Thu, 24 Nov 2022 06:27:29 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH liburing v1 1/7] liburing.h: Export `__io_uring_flush_sq()` function To: Ammar Faizi , Dylan Yudaken Cc: Pavel Begunkov , Gilang Fachrezy , Alviro Iskandar Setiawan , Muhammad Rizki , io-uring Mailing List , GNU/Weeb Mailing List , VNLX Kernel Department References: <20221124075846.3784701-1-ammar.faizi@intel.com> <20221124075846.3784701-2-ammar.faizi@intel.com> Content-Language: en-US From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit List-Id: On 11/24/22 4:47 AM, Ammar Faizi wrote: > On 11/24/22 5:14 PM, Dylan Yudaken wrote: >> I think changing the tests to use the public API is probably better >> than exporting this function. I don't believe it has much general use? > > But there is no public API that does the same thing. I'll mark it > as static and create a copy of that function in iopoll.c (in v2). > > Something like this, what do you think? Yeah I think this is better for now, and then we can work on fixing the test. Sanity of the core parts of the library is a lot more important than some test case. -- Jens Axboe