GNU/Weeb Mailing List <[email protected]>
 help / color / mirror / Atom feed
From: Muhammad Rizki <[email protected]>
To: Ammar Faizi <[email protected]>
Cc: Alviro Iskandar Setiawan <[email protected]>,
	GNU/Weeb Mailing List <[email protected]>
Subject: Re: [PATCH v3 8/9] enum: Add Platform enumeration
Date: Fri, 21 Oct 2022 21:34:16 +0700	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 21/10/2022 21.21, Ammar Faizi wrote:
> 1) It reduces the function call and you don't have to import an
>     extra library. It's simpler to use and to write, it doesn't
>     have to call a function to define the value.
> 

So, you don't want to use extra library or worry about the enum.auto()? 
If you worry about the enum.auto(), then I just simply declare it as a 
number. If you don't want to use the extra library then I follow what 
you want here.

> 
> If using auto generated enum can give us something better at all,
> what is that? Tell me.
> 

It just auto generated name to make it readable when printing out or use 
it as a string value. You can see at gen_temp() in utils.py, I use it as 
its string name value to choose where the temporary folder to create is. 
It's simpler, if you want to declare it as an integer, then it's more 
way complicated because it will use an if statement like the old one does.

What do you think?

  reply	other threads:[~2022-10-21 14:34 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-21 13:45 [PATCH v3 0/9] Fix some bugs and add some features Muhammad Rizki
2022-10-21 13:45 ` [PATCH v3 1/9] discord: Add send_text_mail_interaction() Muhammad Rizki
2022-10-21 13:45 ` [PATCH v3 2/9] discord: Add send_patch_mail_interaction() Muhammad Rizki
2022-10-21 13:45 ` [PATCH v3 3/9] discord: Add get lore mail slash command Muhammad Rizki
2022-10-21 13:45 ` [PATCH v3 4/9] atom: Improve remove_patch() Muhammad Rizki
2022-10-21 13:45 ` [PATCH v3 5/9] atom: add manage_payload() Muhammad Rizki
2022-10-21 14:01   ` Ammar Faizi
2022-10-21 14:02     ` Muhammad Rizki
2022-10-21 14:06       ` Ammar Faizi
2022-10-21 14:07         ` Muhammad Rizki
2022-10-21 13:45 ` [PATCH v3 6/9] telegram: Fix get lore command Muhammad Rizki
2022-10-21 13:45 ` [PATCH v3 7/9] atom: Improve extract_body() Muhammad Rizki
2022-10-21 14:34   ` Alviro Iskandar Setiawan
2022-10-21 13:45 ` [PATCH v3 8/9] enum: Add Platform enumeration Muhammad Rizki
2022-10-21 14:02   ` Ammar Faizi
2022-10-21 14:04     ` Muhammad Rizki
2022-10-21 14:21       ` Ammar Faizi
2022-10-21 14:34         ` Muhammad Rizki [this message]
2022-10-21 14:45           ` Ammar Faizi
2022-10-21 14:54             ` Muhammad Rizki
2022-10-21 15:07               ` Ammar Faizi
2022-10-21 15:10                 ` Muhammad Rizki
2022-10-21 15:08               ` Ammar Faizi
2022-10-21 15:12                 ` Muhammad Rizki
2022-10-21 15:21                   ` Ammar Faizi
2022-10-21 15:35                     ` Muhammad Rizki
2022-10-21 15:37                       ` Ammar Faizi
2022-10-21 15:54                         ` Muhammad Rizki
2022-10-21 15:59                           ` Ammar Faizi
2022-10-21 15:39                       ` Ammar Faizi
2022-10-21 15:45                         ` Muhammad Rizki
2022-10-21 15:48                           ` Ammar Faizi
2022-10-21 18:29                             ` Muhammad Rizki
2022-10-21 18:53                               ` Ammar Faizi
2022-10-21 19:05                                 ` Alviro Iskandar Setiawan
2022-10-21 19:15                                   ` Ammar Faizi
2022-10-21 19:24                                     ` Alviro Iskandar Setiawan
2022-10-21 19:07                                 ` Muhammad Rizki
2022-10-21 17:03                     ` Alviro Iskandar Setiawan
2022-10-21 13:45 ` [PATCH v3 9/9] enum: Use the created Platform class enumeration Muhammad Rizki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox