From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by gnuweeb.org (Postfix) with ESMTPS id 95CDF8060C for ; Fri, 9 Sep 2022 07:07:42 +0000 (UTC) Authentication-Results: gnuweeb.org; dkim=pass (2048-bit key; unprotected) header.d=bytedance-com.20210112.gappssmtp.com header.i=@bytedance-com.20210112.gappssmtp.com header.a=rsa-sha256 header.s=20210112 header.b=TPbzxpyP; dkim-atps=neutral Received: by mail-pl1-f181.google.com with SMTP id b21so956304plz.7 for ; Fri, 09 Sep 2022 00:07:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=5aQOmj4o6dy+y08Ndf5GP3ShJjdt3XzOKjEopk6m/lE=; b=TPbzxpyPzcDS/2Mu6bTugXg7Evw4zdwAU0ETEKmg6oSWWB2dTr0yCd8rRlVpzZTD1l A1JKGtlEa0KKAHnmb+DDf+HKhQB668P2MfErJ6E5wZHnjAIL1mElQWdH5FKfI3W14tdy l9eT1NqeubKDL1nNpHkATVRpnvKrBACw0b5+ALb4uPettYoqHeky9E7npLq2k5gWqO9T qCFcN6LLBYM+d0vhgF6eip5CM28zPLH4E8FAWfobeL7XGAzzvBC6zy8nNm3bH5ef4aHu TJvYlg09bqHC4hAh5HmNT8ubJngGXLekNnWPU7Stnvz7/UNY8A8x4NOke49aPy9HmgqU qbsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=5aQOmj4o6dy+y08Ndf5GP3ShJjdt3XzOKjEopk6m/lE=; b=k4awLZWSCUBTpvP3Vm/R3w9ExL8c5wbUJP2VP8ukUrUK38VLoYTzUHHa1J5NgpHT9t conDcZJBK5HSwLJF69djhdk66Dpgt8oe/KWclB/RiYY9gLlXsOhanNYg6VHBr1BJHiIN WVT4x7g0JJKd5eWwyMaBsYhm+bXu/EpfhaydR4VIHU5GdSGfx6aURR3Dnu0m67d3cffN i5hE2RjZfCy1sCSHO7+FFTe9LV1Z3j6LT4Q88Lq7Nl+sDXykg7hQkEu6V64YnjdGeBWJ tYcPbh1D8A1ae3rArItx1fH4OOoES8be1KXeUcXHGSQLB0EGQXp9duG/ONw/jQPs4Wa+ e3Cw== X-Gm-Message-State: ACgBeo2lxJAhm6JTQvqdRpW6f+NaQti7/jxoxWHr1ks1+hfKviqxehJj UIHUOAK/PGEkvfEYri5I3zelqA== X-Google-Smtp-Source: AA6agR6KbyVvA8JXAeum23FDcoKOigidJa7JqE+5eS/1/Rhp7TmDzQkmZjEuOFLqTQBJiEbYW6ZhDg== X-Received: by 2002:a17:90a:c711:b0:202:5cda:765c with SMTP id o17-20020a17090ac71100b002025cda765cmr8330639pjt.35.1662707262018; Fri, 09 Sep 2022 00:07:42 -0700 (PDT) Received: from [10.4.108.105] ([139.177.225.250]) by smtp.gmail.com with ESMTPSA id cv8-20020a17090afd0800b001fb53587166sm656041pjb.28.2022.09.09.00.07.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Sep 2022 00:07:41 -0700 (PDT) Message-ID: <69409ea6-6daa-7973-c950-c6ca9ad96f50@bytedance.com> Date: Fri, 9 Sep 2022 15:07:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: [ammarfaizi2-block:arm64/linux/for-next/misc 2/2] arch/arm64/kernel/irq.c:81:6: warning: no previous prototype for function 'do_softirq_own_stack' Content-Language: en-US To: Arnd Bergmann , kernel test robot , Catalin Marinas Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, Ammar Faizi , GNU/Weeb Mailing List , linux-kernel@vger.kernel.org References: <202209091157.akimiv18-lkp@intel.com> From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: On 2022/9/9 14:30, Arnd Bergmann wrote: > On Fri, Sep 9, 2022, at 5:12 AM, kernel test robot wrote: >> tree: https://github.com/ammarfaizi2/linux-block >> arm64/linux/for-next/misc >> head: 2d2f3bb897a3de4190b1b6b296c3429d01327554 >> commit: 2d2f3bb897a3de4190b1b6b296c3429d01327554 [2/2] arm64: run >> softirqs on the per-CPU IRQ stack >> config: arm64-randconfig-r023-20220907 >> compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project >> 1546df49f5a6d09df78f569e4137ddb365a3e827) >> reproduce (this is a W=1 build): >> wget >> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross >> -O ~/bin/make.cross >> chmod +x ~/bin/make.cross >> # install arm64 cross compiling tool for clang build >> # apt-get install binutils-aarch64-linux-gnu >> # >> https://github.com/ammarfaizi2/linux-block/commit/2d2f3bb897a3de4190b1b6b296c3429d01327554 >> git remote add ammarfaizi2-block >> https://github.com/ammarfaizi2/linux-block >> git fetch --no-tags ammarfaizi2-block arm64/linux/for-next/misc >> git checkout 2d2f3bb897a3de4190b1b6b296c3429d01327554 >> # save the config file >> mkdir build_dir && cp config build_dir/.config >> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 >> O=build_dir ARCH=arm64 SHELL=/bin/bash arch/arm64/kernel/ >> >> If you fix the issue, kindly add following tag where applicable >> Reported-by: kernel test robot >> >> All warnings (new ones prefixed by >>): >> >>>> arch/arm64/kernel/irq.c:81:6: warning: no previous prototype for function 'do_softirq_own_stack' [-Wmissing-prototypes] >> void do_softirq_own_stack(void) >> ^ >> arch/arm64/kernel/irq.c:81:1: note: declare 'static' if the function >> is not intended to be used outside of this translation unit >> void do_softirq_own_stack(void) >> ^ >> static > > > I think we are missing an "#include " > in arch/arm64/kernel/irq.c Indeed. Hi Catalin, do I need to resend the v4 version? Or can you help me to apply the following code change to the for-next/misc directly? Both are fine for me, depending on which way is convenient for you. :) diff --git a/arch/arm64/kernel/irq.c b/arch/arm64/kernel/irq.c index c36ad20a52f3..181df57c812b 100644 --- a/arch/arm64/kernel/irq.c +++ b/arch/arm64/kernel/irq.c @@ -23,6 +23,7 @@ #include #include #include +#include /* Only access this in an NMI enter/exit */ DEFINE_PER_CPU(struct nmi_ctx, nmi_contexts); BTW, when I just compiled the kernel with W=1, I found a lot of compilation warnings, which is somewhat unexpected. Thanks, Qi > > Arnd -- Thanks, Qi