From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ammarfaizi2@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,NO_DNS_FOR_FROM,
	URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
Received: from [10.7.7.5] (unknown [182.253.183.247])
	by gnuweeb.org (Postfix) with ESMTPSA id 7423D80908;
	Fri, 21 Oct 2022 14:03:01 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=default; t=1666360982;
	bh=Y3BwGVpwiCe25BuTRkZ5dWpH/VDHMIVHByG3vY1+5os=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=ZaV1dZrqtxAGiRTkccQOlgrbD05AsuVElXZLypdokfSWmU09u8PbYMG7j9gaLQGxK
	 fj/j5AC5hhbklzJWN1L+0X3ExRf98Sq3I66VnI4AYStjs3GR3sxQDvgDC6IRUNyhwY
	 eoc0GG1pR2mzHhCuqU4w5C/Y3a5CbqI+GJF2GDqhXkPVHXMlPwRniC6wb/goenwW8z
	 kzX1+HnOTTCn/BSx+bsQX1FJPLrZYGIwcZcDpmohMILhQPUeBJZD6lRSnuxmzpR348
	 7RTkc9OJkybsVuL/mKB5r8qVFOHbL4UD2bfDkhXiUWw6Q23wQ61iy6UnPy1GBbzK1/
	 grKP4/tSgXQDg==
Message-ID: <6fb1d238-de6a-325c-8d17-6801ae24c717@gnuweeb.org>
Date: Fri, 21 Oct 2022 21:02:58 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v3 8/9] enum: Add Platform enumeration
Content-Language: en-US
To: Muhammad Rizki <kiizuha@gnuweeb.org>
Cc: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
 GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
References: <20221021134520.701-1-kiizuha@gnuweeb.org>
 <20221021134520.701-9-kiizuha@gnuweeb.org>
From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
In-Reply-To: <20221021134520.701-9-kiizuha@gnuweeb.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: <gwml.vger.gnuweeb.org>

On 10/21/22 8:45 PM, Muhammad Rizki wrote:
> --- /dev/null
> +++ b/daemon/enums/platform.py
> @@ -0,0 +1,7 @@
> +import enum
> +from .base import EnumBase
> +
> +
> +class Platform(EnumBase):
> +	DISCORD = enum.auto()
> +	TELEGRAM = enum.auto()

Why is this necessary to be auto generated enum?

I don't see any reason of why we should use an extra library
here. I would just define them manually like:

    DISCORD  = 1
    TELEGRAM = 2

Thoughts?

-- 
Ammar Faizi