From: Muhammad Rizki <[email protected]>
To: Ammar Faizi <[email protected]>
Cc: Alviro Iskandar Setiawan <[email protected]>,
Irvan Malik Azantha <[email protected]>,
Memet Zx <[email protected]>,
GNU/Weeb Mailing List <[email protected]>
Subject: Re: [PATCH v1 0/1] Add tailwind configuration
Date: Tue, 26 Sep 2023 22:55:38 +0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 26/09/2023 19.15, Ammar Faizi wrote:
> On Tue, Sep 26, 2023 at 07:00:26PM +0700, Muhammad Rizki wrote:
>> Hai, this is just a small patch for tailwind config:
>> - Add JS and CSS to the `tailwind.config.js` on content detection.
>
> I don't understand what the problem is. Please explain what goes wrong.
> Also, add a "Fixes" tag in the patch, mention the offending commit.
It seems Tailwind does not detect class name properly inside inline
JavaScript that contains like `element.classList.add(...,
getColor({first_name}))`, in dev environment, it is working properly in
my device that user profile name and border color are not white colors.
Maybe Irvan knows how to fix it?
>
>> Please test it first on your device and look for reply UI border color
>> and user profile name text color, if it's not white then it works,
>> thanks!
>
> Therefore, it doesn't work. After applying your patch and running "npm
> run build" plus clear cache, I see white and blue on two different
> messages.
>
> This is white:
>
> https://gist.githubusercontent.com/ammarfaizi2/7ba8aa2f542d260ed6863930b3b1b9d4/raw/a53751c4c0eda0455a2b66e8000e520fe8cfd9e1/Screenshot%2520from%25202023-09-26%252019-06-28.png
>
> This is blue:
>
> https://gist.githubusercontent.com/ammarfaizi2/7ba8aa2f542d260ed6863930b3b1b9d4/raw/a53751c4c0eda0455a2b66e8000e520fe8cfd9e1/Screenshot%2520from%25202023-09-26%252019-06-09.png
>
That's weird, I tried the similar commands on Windows:
- npm run build:css
- Get-Content .\index.html | ForEach-Object { $_ -replace 'dist', '.'
} | Set-Content .\dist\index.html
- robocopy static dist\static
- npm run build:minify
Then open the dist index.html file in the browser and it's working properly.
https://i.ibb.co/GdqLj9y/image.png
next prev parent reply other threads:[~2023-09-26 15:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 12:00 [PATCH v1 0/1] Add tailwind configuration Muhammad Rizki
2023-09-26 12:00 ` [PATCH v1 1/1] fix: add *.js and *.css for tailwind config Muhammad Rizki
2023-09-26 12:15 ` [PATCH v1 0/1] Add tailwind configuration Ammar Faizi
2023-09-26 15:55 ` Muhammad Rizki [this message]
2023-09-26 17:04 ` Ammar Faizi
2023-09-26 17:18 ` Muhammad Rizki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox