public inbox for [email protected]
 help / color / mirror / Atom feed
From: Muhammad Rizki <[email protected]>
To: Ammar Faizi <[email protected]>
Cc: Alviro Iskandar Setiawan <[email protected]>,
	GNU/Weeb Mailing List <[email protected]>,
	Muhammad Rizki <[email protected]>
Subject: Re: [PATCH v1 00/10] Relative Path, Delete Avatar, Sidebar, Toast
Date: Sat, 8 Mar 2025 22:46:38 +0700	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 08/03/2025 22:28, Ammar Faizi wrote:
> On Sat, Mar 08, 2025 at 10:21:09PM +0700, Muhammad Rizki wrote:
>> can you try to clear the localStorage?
> 
> As already explained, it works if I clear the localStorage manually.
> 
>> it could be because of previous state
>> of user_info is not synchronized with current API structure.
> 
> No. After clearing the localStorage, I tried to relogin and purposely
> invalidate gwm_token by doing:
> 
>    localStorage.setItem("gwm_token", "aaaaaa")
> 
> I expect I get logged out immediately after reload. But no, it throws
> "500 Internal Error" on invalid token.
> 
> Invalid or expired token should not trap user in "500 Internal Error"
> page.
> 
> And whatever the user throws at you, you are not allowed to crash. You
> must recover from unexpected scenario.
> 

what I'm trying to say is:
the `null` value is because of API structure changes, but yeah good 
catch there, if user manually set the state it should throw user to 
login page, I will try to patch that issue, thanks.

      reply	other threads:[~2025-03-08 15:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-07 19:26 [PATCH v1 00/10] Relative Path, Delete Avatar, Sidebar, Toast Muhammad Rizki
2025-03-07 19:26 ` [PATCH v1 01/10] fix(svelte): use relative false Muhammad Rizki
2025-03-07 19:26 ` [PATCH v1 02/10] fix(avatar): change avatarImg state to use from auth.user.photo state Muhammad Rizki
2025-03-07 19:26 ` [PATCH v1 03/10] chore(profile): add toUpperCase() on getShortName() Muhammad Rizki
2025-03-07 19:26 ` [PATCH v1 04/10] fix(profile): make social fields default to empty string Muhammad Rizki
2025-03-07 19:26 ` [PATCH v1 05/10] chore(toaster): change toast message position and use richColors Muhammad Rizki
2025-03-07 19:26 ` [PATCH v1 06/10] chore(profile): reset password value on success Muhammad Rizki
2025-03-07 19:26 ` [PATCH v1 07/10] fix(profile-avatar): add delete avatar method Muhammad Rizki
2025-03-07 19:26 ` [PATCH v1 08/10] chore(profile): add space for password confirmation form Muhammad Rizki
2025-03-07 19:26 ` [PATCH v1 09/10] feat(ui): add dropdown-menu and update bits-ui version Muhammad Rizki
2025-03-07 19:26 ` [PATCH v1 10/10] chore(sidebar-menu): change sidebar menu look Muhammad Rizki
2025-03-08 15:18 ` [PATCH v1 00/10] Relative Path, Delete Avatar, Sidebar, Toast Ammar Faizi
2025-03-08 15:21   ` Muhammad Rizki
2025-03-08 15:28     ` Ammar Faizi
2025-03-08 15:46       ` Muhammad Rizki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox