From: Ammar Faizi <[email protected]>
To: Jens Axboe <[email protected]>
Cc: io-uring Mailing List <[email protected]>,
GNU/Weeb Mailing List <[email protected]>
Subject: Re: [PATCH liburing 2/2] test/Makefile: Append `.test` to the test binary filename
Date: Mon, 4 Apr 2022 00:21:23 +0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 4/3/22 11:43 PM, Jens Axboe wrote:
> On 4/3/22 9:38 AM, Ammar Faizi wrote:
>> When adding a new test, we often forget to add the new test binary to
>> `.gitignore`. Append `.test` to the test binary filename, this way we
>> can use a wildcard matching "test/*.test" in `.gitignore` to ignore all
>> test binary files.
>>
>> Goals:
>> - Make the .gitignore simpler.
>> - Avoid the burden of adding a new test to .gitignore.
>
> Just a cosmetic issue, but the .test does bother me a bit. Probably just
> because we aren't used to it. Maybe let's just call them .t? And we
> should probably rename the foo-test.c cases to just foo.c as a prep patch
> too.
Yes, I agree. Will do it in the next version.
--
Ammar Faizi
prev parent reply other threads:[~2022-04-03 17:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-03 15:38 [PATCH liburing 0/2] Simplify build for tests and a gitignore cleanup Ammar Faizi
2022-04-03 15:38 ` [PATCH liburing 1/2] test/Makefile: Append -lpthread for all tests Ammar Faizi
2022-04-03 15:38 ` [PATCH liburing 2/2] test/Makefile: Append `.test` to the test binary filename Ammar Faizi
2022-04-03 16:43 ` Jens Axboe
2022-04-03 17:21 ` Ammar Faizi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox