From: Ammar Faizi <[email protected]>
To: Alviro Iskandar Setiawan <[email protected]>,
Jens Axboe <[email protected]>
Cc: Pavel Begunkov <[email protected]>,
Alviro Iskandar Setiawan <[email protected]>,
[email protected], [email protected]
Subject: Re: [PATCH liburing 2/2] src/Makefile: Add header files as dependency
Date: Wed, 9 Mar 2022 05:58:55 +0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 3/9/22 5:40 AM, Alviro Iskandar Setiawan wrote:
> When the header files are modified, the compiled object are not going
> to be recompiled because the header files are not marked as dependency
> for the objects. Add those header files as dependency so it is safe
> not to do "make clean" after changing those files.
Another missing part is the test files, they should also be recompiled
when changes to files in src/ are made. With this change, they are not.
The same also for examples/.
--
Ammar Faizi
next prev parent reply other threads:[~2022-03-08 22:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-08 22:40 [PATCH liburing 0/2] Changes for src/Makefile Alviro Iskandar Setiawan
2022-03-08 22:40 ` [PATCH liburing 1/2] src/Makefile: Remove `-fomit-frame-pointer` from default build Alviro Iskandar Setiawan
2022-03-08 22:40 ` [PATCH liburing 2/2] src/Makefile: Add header files as dependency Alviro Iskandar Setiawan
2022-03-08 22:52 ` Ammar Faizi
2022-03-08 23:06 ` Alviro Iskandar Setiawan
2022-03-09 0:23 ` Alviro Iskandar Setiawan
2022-03-09 0:41 ` Ammar Faizi
2022-03-08 22:58 ` Ammar Faizi [this message]
2022-03-08 23:07 ` Alviro Iskandar Setiawan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox