Re: [PATCH v1 06/11] Add traceback to get the error detail

[Ammar Faizi <ammarfaizi2@gnuweeb.org>]

On 7/18/22 6:20 PM, Muhammad Rizki wrote:
> Signed-off-by: Muhammad Rizki <riskimuhammmad1@gmail.com>
> ---
>   daemon/scraper/bot.py | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)

Please give the reason of why do you make changes in this patch.

That patch is not trivial as it has a lengthy discussion background
story. It's something that needs an explanation. Not an empty body
like that.

A good commit message should explain "WHY" such a change is
necessary.

Maybe you can write it like this:

     daemon: Use traceback.format_exc() to get the error detail

     `print(f"[__run]: Error: {e}")` doesn't give enough information for
     debugging because it doesn't show the traceback, files, line numbers,
     etc. It only shows the error message raised by an exception. This is
     severely lacking and very bad for debugging experience.

     Use `traceback.format_exc()` instead to get a better log because it
     shows a complete traceback of the error.

     Signed-off-by: Your Name <your_email@somehwere.com>

Improve it yourself if needed.

-- 
Ammar Faizi