From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ammarfaizi2@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,NO_DNS_FOR_FROM,
	OBFU_UNSUB_UL,URIBL_BLOCKED autolearn=no autolearn_force=no
	version=3.4.6
Received: from [192.168.88.254] (unknown [125.160.110.145])
	by gnuweeb.org (Postfix) with ESMTPSA id 386817E328;
	Mon, 18 Jul 2022 11:27:46 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=default; t=1658143668;
	bh=yHKAXhmXOvzdlLXnOPquaspCZC7UmPB3Mhe6s5mcxfA=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=OUgNw07SrsKyKx817ZaLsllWo67GtIhU2cijIOO0KFxPKMpWUo3c1aBi/7e4cndqu
	 L4I3Ft1IvpUeV15jiUMV112rsWvi/efPOGA9d6SbuGV7NcwkMr6eqMtgkDsasgNwC6
	 igsKi8hwXEyoyWumgi7Ia8UcKRoJIOLjSSvE6FXxVhSFR3VQE1iZDd5lU/79qEHlGi
	 O187GNIY0lydbV+YlYul/sMJTJ8y9I+juU8QteDRVhEnWyTYHaECqjagV9TmYYSQdU
	 ceRZe8ON4r0zG+TUhvr7nZlXa3Vw+bhJzwwOuaG++UlwNA/yDiPXt967E4f757Ri92
	 /2sx4/HjcPr4A==
Message-ID: <759288de-6f44-12bf-434b-708f42f5a825@gnuweeb.org>
Date: Mon, 18 Jul 2022 18:27:43 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v1 06/11] Add traceback to get the error detail
Content-Language: en-US
To: Muhammad Rizki <riskimuhammmad1@gmail.com>
Cc: GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
References: <20220718112007.792-1-riskimuhammmad1@gmail.com>
 <20220718112007.792-7-riskimuhammmad1@gmail.com>
From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
In-Reply-To: <20220718112007.792-7-riskimuhammmad1@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: <gwml.vger.gnuweeb.org>

On 7/18/22 6:20 PM, Muhammad Rizki wrote:
> Signed-off-by: Muhammad Rizki <riskimuhammmad1@gmail.com>
> ---
>   daemon/scraper/bot.py | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)

Please give the reason of why do you make changes in this patch.

That patch is not trivial as it has a lengthy discussion background
story. It's something that needs an explanation. Not an empty body
like that.

A good commit message should explain "WHY" such a change is
necessary.

Maybe you can write it like this:

     daemon: Use traceback.format_exc() to get the error detail

     `print(f"[__run]: Error: {e}")` doesn't give enough information for
     debugging because it doesn't show the traceback, files, line numbers,
     etc. It only shows the error message raised by an exception. This is
     severely lacking and very bad for debugging experience.

     Use `traceback.format_exc()` instead to get a better log because it
     shows a complete traceback of the error.

     Signed-off-by: Your Name <your_email@somehwere.com>

Improve it yourself if needed.

-- 
Ammar Faizi