public inbox for gwml@vger.gnuweeb.org
 help / color / mirror / Atom feed
From: Muhammad Rizki <kiizuha@gnuweeb.org>
To: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Cc: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
	Irvan Malik Azantha <irvanma@gnuweeb.org>,
	Memet Zx <zxce3@gnuweeb.org>,
	GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
Subject: Re: [PATCH v1 12/13] chore(README): update README.md
Date: Sat, 7 Oct 2023 12:36:12 +0700	[thread overview]
Message-ID: <7a3ee1a9-76c7-07bb-cddd-96834100f8ec@gnuweeb.org> (raw)
In-Reply-To: <e9eb55ee-7408-4791-86b3-a81adcb097d9@gnuweeb.org>

On 06/10/2023 02.29, Ammar Faizi wrote:
> On 10/3/23 9:51 AM, Muhammad Rizki wrote:
>> +## Production Build Server
>> +
>> +To run the production build node server, issue this command:
>> +
>> +```bash
>> +node dist
>> +# Listening on 0.0.0.0:3000
>> +```
> 
> Why is this needed? I don't see the need to run an additional web
> server to serve a static website. I expect to have only nginx to run
> https://www.gnuweeb.org .

OK

> 
> You may argue you need extra backend code to fetch the API in patch
> #10, but why should you do that in the backend? Can't you move that
> functionality to the client side JavaScript?
> 

Sure, just change the +page.server.ts to +page.ts in order to become 
client-side, I will make v2 for it.

  reply	other threads:[~2023-10-07  5:36 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-03  2:51 [PATCH v1 00/13] GNU/Weeb Web Migration to SvelteKit Muhammad Rizki
2023-10-03  2:51 ` [PATCH v1 01/13] refactor: migrate: migrate to sveltekit framework Muhammad Rizki
2023-10-03  2:51 ` [PATCH v1 02/13] feat(app): add app types file Muhammad Rizki
2023-10-03  2:51 ` [PATCH v1 03/13] feat(lib): add API_URL and STORAGE_URL constant variable Muhammad Rizki
2023-10-03  2:51 ` [PATCH v1 04/13] feat(lib): add lib functions file Muhammad Rizki
2023-10-03  2:51 ` [PATCH v1 05/13] feat(lib): add newly created lib constants variables and functions Muhammad Rizki
2023-10-03  2:51 ` [PATCH v1 06/13] feat(lib/functions): add getRepliedMessage() function Muhammad Rizki
2023-10-03  2:51 ` [PATCH v1 07/13] feat(lib/functions): add dateFormat() function Muhammad Rizki
2023-10-03  2:51 ` [PATCH v1 08/13] feat(components): add <OrganizationMembers/> component Muhammad Rizki
2023-10-03  2:51 ` [PATCH v1 09/13] feat(components): add <RecentMessages/> component Muhammad Rizki
2023-10-03  2:51 ` [PATCH v1 10/13] feat(routes): add +page.server.ts Muhammad Rizki
2023-10-03  2:51 ` [PATCH v1 11/13] feat(routes/page): add +page.svelte Muhammad Rizki
2023-10-03  2:51 ` [PATCH v1 12/13] chore(README): update README.md Muhammad Rizki
2023-10-05 19:29   ` Ammar Faizi
2023-10-07  5:36     ` Muhammad Rizki [this message]
2023-10-03  2:51 ` [PATCH v1 13/13] chore: remove unused files Muhammad Rizki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7a3ee1a9-76c7-07bb-cddd-96834100f8ec@gnuweeb.org \
    --to=kiizuha@gnuweeb.org \
    --cc=alviro.iskandar@gnuweeb.org \
    --cc=ammarfaizi2@gnuweeb.org \
    --cc=gwml@vger.gnuweeb.org \
    --cc=irvanma@gnuweeb.org \
    --cc=zxce3@gnuweeb.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox