From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NO_DNS_FOR_FROM,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 Received: from [192.168.1.101] (unknown [88.235.220.59]) by gnuweeb.org (Postfix) with ESMTPSA id 6419E7E2F3; Thu, 17 Mar 2022 13:16:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1647522994; bh=5fmrA3PukZjwJ+KCbiuPihtvucTo0WoBkiBojIPQC+E=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=TjwkIQZGniiLHugynrg1EpLzHpECUGp9+Uk1nazx14oOaJ2DXbgoCwuxWZU2PB43F IaE6QWBf4NsGt4gPtE6XDtlmDRXiRgo7Zk8bFLwpIY18ZXz5FvUbz6Psjp7igY3YkI lqzx7MTw6qUhehgi62SHNsT3iFuSwresujmjTfQL9N4GOdOkFrrvw3D5c/r9m3QbOB /PdST/HM95MId091Zn24isCbFCMuQjcMJURVTL5VhXLPkOSs8oWDL/qD6wJKkY5TcC dFWt1OOrV766r21SG4orJKV6NbbTD7LIiueIe+1tANKEXuEOKh/2qXnlP3u9rXsS+3 hwc/KQB9mhtXg== Message-ID: <7b4f98d92a57af35c927aef6c85373f8eeeab29c.camel@gnuweeb.org> Subject: Re: [PATCH] boot install: Partially refactor the logic for detecting bootloader From: Beru Shinsetsu To: Boris Petkov , Thomas Gleixner Cc: Ingo Molnar , Dave Hansen , "H. Peter Anvin" , x86@kernel.org, GNU/Weeb Mailing List , linux-kernel@vger.kernel.org, Alviro Iskandar Setiawan Date: Thu, 17 Mar 2022 16:16:26 +0300 In-Reply-To: <2E28CA0C-34F2-4985-86CC-B1823AF8D747@alien8.de> References: <20220316173221.5937-1-windowz414@gnuweeb.org> <2E28CA0C-34F2-4985-86CC-B1823AF8D747@alien8.de> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit List-Id: On Thu, 2022-03-17 at 12:36 +0000, Boris Petkov wrote: > On March 16, 2022 5:32:21 PM UTC, Beru Shinsetsu > wrote: > > While running `make install` after building the kernel and > > installing > > modules on several distros like EndeavourOS, there would be a > > pretty > > little output (To be exact, "Cannot find LILO") due to lack of LILO > > bootloader, which is really uncommon for a user to have it while > > GRUB is there. > > As a matter of fact I saw this yesterday on one of the test boxes > here and was wondering why I am even seeing this. I guess I had pure luck having this patch seen? xd > So before we do anything, it'd be prudent to know what has changed > recently to cause this error message to happen. Because we would have > to backport a fix to some kernels probably. To be honest with you, nothing has changed _just recently_ to cause this error message to come up. It was a long living thing (since the time LILO check has appeared and the last change to it was in 2007. I can't find when did the check appear for the first time as Linus apparently ripped off the whole history from before 2.16.12-rc2.), just was unseen as most of Linux distros love to ship their own ways to install kernels... except Arch Linux and distros based on it, as they have Arch User Repository to automatically compile the kernel locally and make a PacMan package out of the artifacts using some external package manager like Yay or Aura. And if you have checked the ServerFault forum thread I have appended in original commit message, you can see it was there for really long and has been happening only on Arch Linux or distros based on it, like EndeavourOS. I have also tested this out on my environment (I have EndeavourOS on my laptop's HDD and Ubuntu Budgie on my USB HDD). I get the error message on Endeavour while I don't on Ubuntu Budgie if I run `make install` without this patch I made applied. But if I apply this patch then run it, it works on both. TL;DR, this was something that has been there since 2.x and wasn't patched ever since, so here I do as I figured out how it's handled without requirement of user interaction, through this patch. Commit ripping off the history from before 2.16.12-rc2: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 (Linux-2.6.12-rc2) Last commit towards LILO check: 47f82189b185bf4b0de4ebce237850e8d3b1d0b6 (broken lilo check on make install) > Thx. And I thank you for your attention! :) -- Beru Shinsetsu