From: Stefan Roesch <[email protected]>
To: Jan Kara <[email protected]>
Cc: [email protected], [email protected], [email protected],
[email protected], [email protected],
[email protected], [email protected]
Subject: Re: [PATCH v5 04/16] iomap: Add flags parameter to iomap_page_create()
Date: Thu, 26 May 2022 10:39:22 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 5/26/22 6:43 AM, Jan Kara wrote:
> On Wed 25-05-22 15:34:20, Stefan Roesch wrote:
>> Add the kiocb flags parameter to the function iomap_page_create().
>> Depending on the value of the flags parameter it enables different gfp
>> flags.
>>
>> No intended functional changes in this patch.
>>
>> Signed-off-by: Stefan Roesch <[email protected]>
>
> Just one nit below:
>
>> @@ -226,7 +231,7 @@ static int iomap_read_inline_data(const struct iomap_iter *iter,
>> if (WARN_ON_ONCE(size > iomap->length))
>> return -EIO;
>> if (offset > 0)
>> - iop = iomap_page_create(iter->inode, folio);
>> + iop = iomap_page_create(iter->inode, folio, 0);
>> else
>> iop = to_iomap_page(folio);
>>
>> @@ -264,7 +269,7 @@ static loff_t iomap_readpage_iter(const struct iomap_iter *iter,
>> return iomap_read_inline_data(iter, folio);
>>
>> /* zero post-eof blocks as the page may be mapped */
>> - iop = iomap_page_create(iter->inode, folio);
>> + iop = iomap_page_create(iter->inode, folio, 0);
>> iomap_adjust_read_range(iter->inode, folio, &pos, length, &poff, &plen);
>> if (plen == 0)
>> goto done;
>
> Shouldn't we pass iter->flags to iomap_page_create() in the above two call
> sites? I know functionally it is no different currently but in the future
> it might be less surprising...
>
I made the change.
> With this fixed, feel free to add:
>
> Reviewed-by: Jan Kara <[email protected]>
>
> Honza
next prev parent reply other threads:[~2022-05-26 17:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 22:34 [PATCH v5 00/16] io-uring/xfs: support async buffered writes Stefan Roesch
2022-05-25 22:34 ` [PATCH v5 01/16] mm: Move starting of background writeback into the main balancing loop Stefan Roesch
2022-05-25 22:34 ` [PATCH v5 02/16] mm: Move updates of dirty_exceeded into one place Stefan Roesch
2022-05-25 22:34 ` [PATCH v5 03/16] mm: Add balance_dirty_pages_ratelimited_flags() function Stefan Roesch
2022-05-25 22:34 ` [PATCH v5 04/16] iomap: Add flags parameter to iomap_page_create() Stefan Roesch
2022-05-26 13:43 ` Jan Kara
2022-05-26 17:39 ` Stefan Roesch [this message]
2022-05-25 22:34 ` [PATCH v5 05/16] iomap: Add async buffered write support Stefan Roesch
2022-05-26 13:39 ` Jan Kara
2022-05-25 22:34 ` [PATCH v5 06/16] fs: Add check for async buffered writes to generic_write_checks Stefan Roesch
2022-05-25 22:34 ` [PATCH v5 07/16] fs: add __remove_file_privs() with flags parameter Stefan Roesch
2022-05-25 22:34 ` [PATCH v5 08/16] fs: Split off inode_needs_update_time and __file_update_time Stefan Roesch
2022-05-25 22:34 ` [PATCH v5 09/16] fs: Add async write file modification handling Stefan Roesch
2022-05-25 22:34 ` [PATCH v5 10/16] fs: Optimization for concurrent file time updates Stefan Roesch
2022-05-25 22:34 ` [PATCH v5 11/16] io_uring: Add support for async buffered writes Stefan Roesch
2022-05-25 22:34 ` [PATCH v5 12/16] io_uring: Add tracepoint for short writes Stefan Roesch
2022-05-25 22:34 ` [PATCH v5 13/16] xfs: Specify lockmode when calling xfs_ilock_for_iomap() Stefan Roesch
2022-05-25 22:34 ` [PATCH v5 14/16] xfs: Change function signature of xfs_ilock_iocb() Stefan Roesch
2022-05-25 22:34 ` [PATCH v5 15/16] xfs: Add async buffered write support Stefan Roesch
2022-05-25 22:34 ` [PATCH v5 16/16] xfs: Enable " Stefan Roesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox