From: Jens Axboe <[email protected]>
To: Dmitry Vyukov <[email protected]>
Cc: Hao Xu <[email protected]>,
syzbot <[email protected]>,
[email protected], [email protected],
[email protected], [email protected]
Subject: Re: [syzbot] UBSAN: array-index-out-of-bounds in io_submit_sqes
Date: Tue, 31 May 2022 03:07:10 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <CACT4Y+aqriNp1F5CJofqaxNMM+-3cxNR2nY0tHEtb4YDqDuHtg@mail.gmail.com>
On 5/31/22 3:05 AM, Dmitry Vyukov wrote:
> On Tue, 31 May 2022 at 11:01, Jens Axboe <[email protected]> wrote:
>>
>> On 5/31/22 3:00 AM, Hao Xu wrote:
>>> On 5/31/22 16:45, Jens Axboe wrote:
>>>> On 5/31/22 1:55 AM, syzbot wrote:
>>>>> Hello,
>>>>>
>>>>> syzbot found the following issue on:
>>>>>
>>>>> HEAD commit: 3b46e4e44180 Add linux-next specific files for 20220531
>>>>> git tree: linux-next
>>>>> console output: https://syzkaller.appspot.com/x/log.txt?x=16e151f5f00000
>>>>> kernel config: https://syzkaller.appspot.com/x/.config?x=ccb8d66fc9489ef
>>>>> dashboard link: https://syzkaller.appspot.com/bug?extid=b6c9b65b6753d333d833
>>>>> compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2
>>>>>
>>>>> Unfortunately, I don't have any reproducer for this issue yet.
>>>>>
>>>>> IMPORTANT: if you fix the issue, please add the following tag to the commit:
>>>>> Reported-by: [email protected]
>>>>>
>>>>> ================================================================================
>>>>> ================================================================================
>>>>> UBSAN: array-index-out-of-bounds in fs/io_uring.c:8860:19
>>>>> index 75 is out of range for type 'io_op_def [47]'
>>>>
>>>> 'def' is just set here, it's not actually used after 'opcode' has been
>>>> verified.
>>>>
>>>
>>> Maybe we can move it to be below the opcode check to comfort UBSAN.
>>
>> Yeah that's what I did, just rebased it to get rid of it:
>>
>> https://git.kernel.dk/cgit/linux-block/commit/?h=io_uring-5.19&id=fcde59feb1affb6d56aecadc3868df4631480da5
>
> If you are rebasing it, please add the following tag so that the bug
> is closed later:
>
> Tested-by: [email protected]
Sorry, missed that, would be a bit confusing? 5.20 branch is rebased
on top of that too. Can we just do:
#syz fix: io_uring: add io_op_defs 'def' pointer in req init and issue
?
--
Jens Axboe
next prev parent reply other threads:[~2022-05-31 9:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 7:55 [syzbot] UBSAN: array-index-out-of-bounds in io_submit_sqes syzbot
2022-05-31 8:45 ` Jens Axboe
2022-05-31 8:52 ` Dmitry Vyukov
2022-05-31 8:56 ` Jens Axboe
2022-05-31 9:00 ` Hao Xu
2022-05-31 9:01 ` Jens Axboe
2022-05-31 9:05 ` Dmitry Vyukov
2022-05-31 9:07 ` Jens Axboe [this message]
2022-05-31 9:14 ` Dmitry Vyukov
2022-05-31 9:53 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox