public inbox for [email protected]
 help / color / mirror / Atom feed
From: Ammar Faizi <[email protected]>
To: Alviro Iskandar Setiawan <[email protected]>
Cc: Hazmi Alfarizqi <[email protected]>,
	GNU/Weeb Mailing List <[email protected]>,
	Hazmi Alfarizqi <[email protected]>
Subject: Re: [PATCH server-a001 v2 3/4] Create `storage` directory for saving persistent data
Date: Sun, 1 May 2022 00:54:44 +0700	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 5/1/22 12:39 AM, Ammar Faizi wrote:
> On 5/1/22 12:30 AM, Alviro Iskandar Setiawan wrote:
>> You made typos:
>>
>>    s/commited/committed
>>    s/commiting/committing
>>
>> Also, public-inbox is a git tree too, so the former sentence is wrong.
>> But I understand the point of this patch.
> 
> Oh yeah, you're right. When I was working on this patch I didn't think
> about other services, only MySQL in my mind. I will fix them all.
> 
> Thanks!

Fixed, it looks like this now. Thanks!

---
From: Ammar Faizi <[email protected]>
Subject: [PATCH 3/4] Create `storage` directory for saving persistent data

This is a directory to save persistent data across `docker run`. All
files inside this directory are ignored by git. They shouldn't be
committed to the same git tree together with `server-a001` project.
The first use case of this directory is for the MySQL data. The
container will mount particular directories inside this `storage`
directory.

Side note: For data backup, the data inside the `storage` directory
should be backed up independently with this tree.

[ammarfaizi2: Reword the commit message]

Link: https://lore.gnuweeb.org/gwml/[email protected]

Reviewed-by: Alviro Iskandar Setiawan <[email protected]>
Signed-off-by: Ammar Faizi <[email protected]>
---
  storage/.gitignore | 2 ++
  1 file changed, 2 insertions(+)
  create mode 100644 storage/.gitignore

diff --git a/storage/.gitignore b/storage/.gitignore
new file mode 100644
index 0000000..d6b7ef3
--- /dev/null
+++ b/storage/.gitignore
@@ -0,0 +1,2 @@
+*
+!.gitignore


-- 
Ammar Faizi

  reply	other threads:[~2022-04-30 17:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-30 17:08 [PATCH server-a001 v2 0/4] Install net-tools and MySQL server Ammar Faizi
2022-04-30 17:08 ` [PATCH server-a001 v2 1/4] Install net-tools Ammar Faizi
2022-04-30 17:08 ` [PATCH server-a001 v2 2/4] Install MySQL server Ammar Faizi
2022-04-30 17:24   ` Alviro Iskandar Setiawan
2022-04-30 17:08 ` [PATCH server-a001 v2 3/4] Create `storage` directory for saving persistent data Ammar Faizi
2022-04-30 17:30   ` Alviro Iskandar Setiawan
2022-04-30 17:39     ` Ammar Faizi
2022-04-30 17:54       ` Ammar Faizi [this message]
2022-05-01 12:13   ` Hazmi Alfarizqi
2022-04-30 17:08 ` [PATCH server-a001 v2 4/4] Create start.sh to start the docker container Ammar Faizi
2022-04-30 17:32   ` Alviro Iskandar Setiawan
2022-05-01 12:15   ` Hazmi Alfarizqi
2022-05-01 13:45     ` Ammar Faizi
2022-05-01 15:09       ` Hazmi Alfarizqi
2022-05-01 15:13         ` Ammar Faizi
2022-04-30 17:10 ` [PATCH server-a001 v2 0/4] Install net-tools and MySQL server Ammar Faizi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox