From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,NO_DNS_FOR_FROM, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from [10.7.7.5] (unknown [182.253.183.184]) by gnuweeb.org (Postfix) with ESMTPSA id 254F67E3B8; Tue, 3 Jan 2023 07:25:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1672730713; bh=c9QBlaYaV/Zapio7yL0VjfxMAaxKLh9eVGrtVseHhtU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=rpXlZUIeE+VWJJYLiWylVnMm73i28E2ZOARtz9VJK29s8KQLXrxYtY5UHCiahykGu 4Gf2JS5RZ1JEjDSKvJB4DjVUqWnBvOyMTeulEuSwWqYMyhJn39KNRVh+B6SSox/6zd 64qA7Cd23FB8ukMWfxcAjwYu5qe7ucvxaZ/MrBQH8FaJXNHFr9G0MSeV7W2q/Adw7Y oyIBj5BAV+DBCbtOGBTXfoOEIngrG6RrLbL7LykTuxZT6eyu+FVC+jTIYemLGJv3I0 jqW3+0GXhDLMzg1fgsmvqwBdjvWI5jk5Jz8UmXuyQXVPjPxtKUr7LwVZEXH7qzE594 8wae8SvnSFiIw== Message-ID: <7e8ec840-7b75-3ffc-90d3-72a3a7aaf6b6@gnuweeb.org> Date: Tue, 3 Jan 2023 14:25:09 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v1 00/13] Improvements, refactors, and features Content-Language: en-US To: Muhammad Rizki Cc: Alviro Iskandar Setiawan , GNU/Weeb Mailing List References: <20230103063641.1680-1-kiizuha@gnuweeb.org> From: Ammar Faizi In-Reply-To: <20230103063641.1680-1-kiizuha@gnuweeb.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: On 1/3/23 1:36 PM, Muhammad Rizki wrote: > Please give it a test and give me more comments or suggestion, thanks! I left several comments to the patches. Please take a look. I skip the testing for this series. I'll do it in v2 (maybe). One more on the commit message convention: > Muhammad Rizki (13): > refactor(discord): Remove unnecessary try/except block > refactor(telegram): Move report_err() to the DaemonClient() class > refactor(telegram)!: Ensure the Telegram bot has been started > feat: add DaemonException() class > feat(telegram): Implement the DaemonException() class > refactor(telegram/mailer)!: Remove unnecessary try/except block > feat(discord): add report_err() for the Discord bot > feat(discord): Implement the report_err() > feat(discord/database): Add ping() method > feat(discord): Add handle_db_error in the listener.py > feat(discord): Handle MySQL connection error in the mail listener > feat(discord): Implement the DaemonException for handle error > refactor(telegram)!: Rename the Telegram bot custom client Please don't use 'feat()' and 'refactor()' as the prefix. I never announced a commit message convention like that for this project. -- Ammar Faizi