Re: [PATCH v2 0/3] New Discord bot and full refactor scripts

[Ammar Faizi <ammarfaizi2@gnuweeb.org>]

On 8/27/22 11:00 PM, Muhammad Rizki wrote:
> On 27/08/2022 17.40, Ammar Faizi wrote:
>> On 8/27/22 10:02 AM, Muhammad Rizki wrote:
>>> Good morning, sir
>>> In this series I created a Discord bot, the functionality and features
>>> still the same with the Telegram bot, this series contains full refactor
>>> both Discord and Telegram bot scripts which is more cleaner.
>>>
>>> Refactors:
>>> Moving the atom related files outside the bot scripts which is can be
>>> reusable with each other bot scripts.
>>> Moving the database related files and create a directory for themselves,
>>> this method is more clean so it's more easier to develop and maintain.
>>> Mass refactor for Telegram and Discord bot scripts.
>>> Combine the SQL file for Discord and Telegram bot, so we don't have to
>>> make a new database.
>> 
>> Can you tell a bit how to setup and test this?
>> 
> 
> How to setup:
> - Install the package first with `requirements.txt` in the `dscord` or 
> `telegram` directory
> - Set the environment in the `daemon` workdir like `discord.env` or 
> `telegram.env`
> - Set the `config.py` for discord or telegram
> - Run the bot by running `python3 dc.py` or `python3 tg.py` in the 
> daemon workdir
> 
> The reason I naming the discord directory with `dscord` is because for
> preventing conflict with `discord.py` library, if you have any question
> just tell me, thanks.

This is just a cosmetic issue, but the naming `dscord` does bother me a
bit. But you don't have to make a change on this at the moment, I will
give it a test before we make further changes.

I didn't have time to test it. Please wait for my feedback (after I manage
to test it) first before sending the next revision.

-- 
Ammar Faizi