From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ammarfaizi2@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,NO_DNS_FOR_FROM,
	URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
Received: from [192.168.210.80] (unknown [182.2.68.216])
	by gnuweeb.org (Postfix) with ESMTPSA id 4A5A68060F;
	Mon, 29 Aug 2022 03:39:13 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=default; t=1661744355;
	bh=Q1zZixpGbpzXQiK+X+Ha3gD4dfgMuwZ/p/uFAxTfllQ=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=MQqqytYHwA3e7A5cfIzw56Z/CqHbtLhoI7DUq/1RREYVfb66si41xQU7msscxPdle
	 vGfs8aT8fhn6wSXi7Ho6UCd1eKFBOshMoZ9CZlTYBRqk0oSDgoEVH4KasC5FuyFngu
	 k9OdUN3r0FiR2zSJ0VGwO+2f/xz8+Xykb3O5Xt+Q45/CBr2ZQw3UTxLmrhZVriwNsv
	 okvEdbmaRYd2qIbMG9lLUksw5uEYxyuAqdDjr5MbL5t0RPn3Rk0zf1fQpyaSu0J8pV
	 ISS3UgB34vRgwGTLQNeI9LdMc5OD1vZAZFC0MY38QA3ipL7cFtaxC0NIk+s+gVFt7t
	 7WZQhE7zPfNbQ==
Message-ID: <80b181d5-279b-66df-4177-11e3a96857de@gnuweeb.org>
Date: Mon, 29 Aug 2022 10:39:11 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v2 0/3] New Discord bot and full refactor scripts
Content-Language: en-US
To: Muhammad Rizki <kiizuha@gnuweeb.org>
Cc: GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>,
 Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
References: <20220827030236.1094-1-kiizuha@gnuweeb.org>
 <bd8ecaff-7586-fdfc-cdfe-9e65c8185d30@gnuweeb.org>
 <7a414bd1-68f1-86a4-e647-7ee071a4300d@gnuweeb.org>
From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
In-Reply-To: <7a414bd1-68f1-86a4-e647-7ee071a4300d@gnuweeb.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: <gwml.vger.gnuweeb.org>

On 8/27/22 11:00 PM, Muhammad Rizki wrote:
> On 27/08/2022 17.40, Ammar Faizi wrote:
>> On 8/27/22 10:02 AM, Muhammad Rizki wrote:
>>> Good morning, sir
>>> In this series I created a Discord bot, the functionality and features
>>> still the same with the Telegram bot, this series contains full refactor
>>> both Discord and Telegram bot scripts which is more cleaner.
>>>
>>> Refactors:
>>> Moving the atom related files outside the bot scripts which is can be
>>> reusable with each other bot scripts.
>>> Moving the database related files and create a directory for themselves,
>>> this method is more clean so it's more easier to develop and maintain.
>>> Mass refactor for Telegram and Discord bot scripts.
>>> Combine the SQL file for Discord and Telegram bot, so we don't have to
>>> make a new database.
>> 
>> Can you tell a bit how to setup and test this?
>> 
> 
> How to setup:
> - Install the package first with `requirements.txt` in the `dscord` or 
> `telegram` directory
> - Set the environment in the `daemon` workdir like `discord.env` or 
> `telegram.env`
> - Set the `config.py` for discord or telegram
> - Run the bot by running `python3 dc.py` or `python3 tg.py` in the 
> daemon workdir
> 
> The reason I naming the discord directory with `dscord` is because for
> preventing conflict with `discord.py` library, if you have any question
> just tell me, thanks.

This is just a cosmetic issue, but the naming `dscord` does bother me a
bit. But you don't have to make a change on this at the moment, I will
give it a test before we make further changes.

I didn't have time to test it. Please wait for my feedback (after I manage
to test it) first before sending the next revision.

-- 
Ammar Faizi