From: Ammar Faizi <[email protected]>
To: Alviro Iskandar Setiawan <[email protected]>
Cc: Kanna Scarlet <[email protected]>,
Muhammad Rizki <[email protected]>,
GNU/Weeb Mailing List <[email protected]>
Subject: Re: [GIT PULL] ncns update (chunked request body support)
Date: Fri, 26 Aug 2022 08:53:53 +0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAOG64qMQeyLrF8fStq+yRh26c=v8Witw41Wi_5Lkyz8ziXdmFQ@mail.gmail.com>
On 8/26/22 8:39 AM, Alviro Iskandar Setiawan wrote:
>> if you split the buffer in the middle of the queue, then you put the
>> rest of the splitted buffer into the tail, then it may get skipped
>> because the EOF mark can be queued earlier. Even if it doesn't hit EOF
>> it's still wrong because the FIFO order is violated when the condition
>> (c.len_ <= dst_len_) evaluates to true
> better way you shouldn't pop the queue if you're running out of
> destination buffer, you can wait for the next ReadInternal() call and
> copy the rest uncopied bytes later time, only the deferring is a bit
> tricky
Ah well, finally got some light!
I understand now, will rework this part later today.
--
Ammar Faizi
next prev parent reply other threads:[~2022-08-26 1:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 9:40 [GIT PULL] ncns update (chunked request body support) Ammar Faizi
2022-08-25 9:57 ` Alviro Iskandar Setiawan
2022-08-25 18:36 ` Ammar Faizi
2022-08-26 1:34 ` Alviro Iskandar Setiawan
2022-08-26 1:39 ` Alviro Iskandar Setiawan
2022-08-26 1:53 ` Ammar Faizi [this message]
2022-08-26 6:24 ` Ammar Faizi
2022-08-26 8:03 ` Ammar Faizi
2022-08-26 8:07 ` Ammar Faizi
2022-08-26 10:37 ` Alviro Iskandar Setiawan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox