From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from gnuweeb.org by gnuweeb.org with LMTP id BVNWNSa6vWLWHTIALGQddQ (envelope-from ) for ; Thu, 30 Jun 2022 14:58:46 +0000 Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) by gnuweeb.org (Postfix) with ESMTPS id 665097F8DC for ; Thu, 30 Jun 2022 14:58:46 +0000 (UTC) Authentication-Results: gnuweeb.org; dkim=pass (2048-bit key; unprotected) header.d=kernel-dk.20210112.gappssmtp.com header.i=@kernel-dk.20210112.gappssmtp.com header.a=rsa-sha256 header.s=20210112 header.b=My/FtdyK; dkim-atps=neutral Received: by mail-io1-f53.google.com with SMTP id h85so19393429iof.4 for ; Thu, 30 Jun 2022 07:58:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=AaW1iBSok+7ZMdnY/5TEfHxpbacDAZPmWERHTCZvLJc=; b=My/FtdyKthbmbH4iTzjWqJDjJ/wX0Z6bl9UBAWEzWIE+NQbnyOGGIUFaLIrvNcKMo9 kETE+HBoL2gs3cbwq9tBkXvys9zwjZunsP6fO9zT18Jb7T/S1mP9olyC2l4VN8Pzn5ro MB1wNWPNRVUVdOxsMYBQFyV9QA7CDElTpHzRKi2WfqMKrDi7lysUnwkhMrmKr/N8rWcy 0oXrNp8AxHZxKrZXpL3iWK5hQ0v/EBaQV3QgQJTU3rBZ2B5ot+Lxe+1FzXmmlJ7HZC+s 21alSEC2zWmOR2jDjGiqZPheieUR+A8aLgKZs+McIDRkPNDjgSqxf5Ke4TpvZuWmGBBz ZYlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=AaW1iBSok+7ZMdnY/5TEfHxpbacDAZPmWERHTCZvLJc=; b=4CP51UfpnjJCoPoLbUG1yfVa/b4FJKkLY9Hsn8FYfl2rOsG+65EtXRtxCZjTPLf6Yy tE6bRuOQTHpZO5aTlRHRPZcK2Vtn3bDfT9KkJB4XuMT28RhkSlLNkrTSHzLmxUI8RH1L loU1fyXo9LG3YP3523LaD2dFC0dgM71G1wlfPXFp/L3QCefa6lFolqlUxn+K+yf33O59 YTxkX9ZNsThOeyyc0IHJ1N7VswzD7rEtRPrRmdVh9W0guxGVU/zAg5cU+xtJQRDexiXk KtlK9RdkZPz+ifYEKoGbO/hDbSzKWg+ce5ESq0+r1tuYdpl6LvudZaFTOEmL3KQXOcF5 WMkA== X-Gm-Message-State: AJIora8zr9I/pWuXGhISyJ696FJw58cwbn8EbsosA1FTNm3DeyAyF8DE lNwSJxh6MramjuY9InozcIcyyg== X-Google-Smtp-Source: AGRyM1vWDaiP7wR60OReqhsp8q18YwUru9UWvy1wRXnkC60oywFlp3NFF9TGqa7KRWaMGXq7PnKN1g== X-Received: by 2002:a6b:d309:0:b0:664:716c:d758 with SMTP id s9-20020a6bd309000000b00664716cd758mr4648308iob.157.1656601065414; Thu, 30 Jun 2022 07:57:45 -0700 (PDT) Received: from [192.168.1.172] ([207.135.234.126]) by smtp.gmail.com with ESMTPSA id z19-20020a05663822b300b00331f1f828adsm8699833jas.16.2022.06.30.07.57.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jun 2022 07:57:45 -0700 (PDT) Message-ID: <831c6fb0-8d31-4867-0510-ae25d41acac6@kernel.dk> Date: Thu, 30 Jun 2022 08:57:44 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH for-next 3/3] test range file alloc Content-Language: en-US To: Pavel Begunkov , io-uring@vger.kernel.org, Ammar Faizi References: <30f95627-eb6c-c743-8fb2-11b0b874e00b@kernel.dk> From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: On 6/30/22 8:19 AM, Pavel Begunkov wrote: > On 6/30/22 14:09, Jens Axboe wrote: >> On 6/30/22 3:13 AM, Pavel Begunkov wrote: >>> @@ -949,5 +1114,11 @@ int main(int argc, char *argv[]) >>> return ret; >>> } >>> + ret = test_file_alloc_ranges(); >>> + if (ret) { >>> + printf("test_partial_register_fail failed\n"); >>> + return ret; >>> + } >> >> If you're returning this directly, test_file_alloc_ranges() should use >> the proper T_EXIT_foo return codes. > > Nobody cared enough to "fix" all tests to use those new codes, most > of the cases just return what they've got, but whatever. Same with > stdout vs stderr. We'll get there eventually, it's just a bad idea to add NEW tests that don't adhere to the new rules. As for stdout vs stderr, by far most of them do it correct. Again, new tests certainly should. -- Jens Axboe