Re: [PATCH v1 4/7] atom: Improve fix_utf8_char()

[Muhammad Rizki <kiizuha@gnuweeb.org>]

On 20/10/2022 00.53, Ammar Faizi wrote:
> On 10/20/22 12:51 AM, Muhammad Rizki wrote:
>> On 20/10/2022 00.42, Ammar Faizi wrote:
>>> On 10/20/22 12:35 AM, Muhammad Rizki wrote:
>>>> Ugh, hate when I should digging up the chat to give a prove. So, you 
>>>> want the re.sub() to be remove or no?
>>>
>>> What I want is: decode the email *properly*, then send it
>>> to Telegram intact.
>>>
>>> That being said, if you have a string ">" in the email
>>> decoded email, it should be still ">" when it is sent
>>> to Telegram. If you have a string ">" in the decode email,
>>> it should be still ">" when it is sent to Telegram. And
>>> so on so forth...
>>>
>>> But what you do here is removing all HTML special chars
>>> after unescape() it twice. I also don't understand why
>>> unescape() should be called twice and nested like that.
>>>
>>> Make me understand why it is necessary doing that is
>>> your job as a submitter.
>>>
>>
>> I know. I forgot where the conversation started, but you said this 
>> https://discord.com/channels/845302963739033611/845302963739033613/1028563014418444348
>>
>> "Just send an empty email that would be fine."
>>
>> Sorry, I don't understand your statement about it. I thought you were 
>> asked me that the HTML contain tags should be empty or what. Please 
>> explain.
> That is because the email is literally an empty email.
> 
> If someone sends an empty email, then just send an empty
> email would be fine.
> 
> I didn't say we should remove all HTML special chars.
> 

In the Telegram bot send that raw lore email URL send an empty email, 
but in the Discord bot, the HTML tags appear. Its from the default email 
payload that why I put re.sub() if `unescape` parameter is `True`, 
because I use the `unescape` parameter if the `platform == "discord"`.

So, should I ignore it when an email payload contains HTML tags even you 
say that email is an empty email and remove the re.sub()?