From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tglx@linutronix.de>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS,
	URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55])
	by gnuweeb.org (Postfix) with ESMTPS id CA977815C9
	for <gwml@vger.gnuweeb.org>; Sat, 12 Nov 2022 17:41:09 +0000 (UTC)
Authentication-Results: gnuweeb.org;
	dkim=pass (2048-bit key; secure) header.d=linutronix.de header.i=@linutronix.de header.a=rsa-sha256 header.s=2020 header.b=J+I06Wlm;
	dkim=pass header.d=linutronix.de header.i=@linutronix.de header.a=ed25519-sha256 header.s=2020e header.b=O1RZFG3z;
	dkim-atps=neutral
From: Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1668274867;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=TcoyRNAdDGi2GFtPX5lXyeqindlf/1rXODkCe/Mq7m8=;
	b=J+I06WlmZx3TZaRprCPcfUdFK9PZTmWViLEOn5G8Jxs01npQJqfqTTtX5/oUCkF5Gedsjt
	51ALTmN7Bsz2RTqQoT7fbqOntfjInE5zrpoF9Urww7paCOmhsKCrtx4xg3pxZBNsJvUKEP
	E5PS+9rxUA+KV/ueBCthDzsNnKmiLrVB4f/hbovWCUaWD+oNUhsWB3xIYmExT5iRB7qSlQ
	8pQmu0+FvufxnoRhB/0b+3rpL6ctd4AcQCKMvfF7mGIg8ON31CpzUiaKWozEE2DvPVFzO7
	yopS7bF6Q1iCbNGmDM5jsohrqKFionhbXX5LY8WCYH+gjc0XhOewTnpdVutD1A==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1668274867;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=TcoyRNAdDGi2GFtPX5lXyeqindlf/1rXODkCe/Mq7m8=;
	b=O1RZFG3z+xLK3eDulsXE3zVDpB50SAxHrh9aUh+ej81/NWzxcz4Ng/iQ/6KujdRKDWcvJb
	G6jJ0KUi+zv0AvBQ==
To: Dan Carpenter <error27@gmail.com>, oe-kbuild@lists.linux.dev, "Ahmed S.
 Darwish" <darwi@linutronix.de>
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, Ammar Faizi
 <ammarfaizi2@gnuweeb.org>, GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
Subject: Re: [ammarfaizi2-block:tglx/devel/devmsi 46/86]
 kernel/irq/msi.c:399 msi_domain_get_virq() warn: inconsistent returns
 '&dev->msi.data->mutex'.
In-Reply-To: <202211070346.0vaondmd-lkp@intel.com>
References: <202211070346.0vaondmd-lkp@intel.com>
Date: Sat, 12 Nov 2022 18:41:06 +0100
Message-ID: <87a64wcbpp.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <gwml.vger.gnuweeb.org>

On Mon, Nov 07 2022 at 15:39, Dan Carpenter wrote:
> smatch warnings:
> kernel/irq/msi.c:399 msi_domain_get_virq() warn: inconsistent returns '&dev->msi.data->mutex'.
>
> vim +399 kernel/irq/msi.c
>
> 495c66aca3da70 Thomas Gleixner  2021-12-06  378  	msi_lock_descs(dev);
> 022573e1aaf074 Ahmed S. Darwish 2022-11-03  379  
> 022573e1aaf074 Ahmed S. Darwish 2022-11-03  380  	base = msi_get_domain_base_index(dev, domid);
> 022573e1aaf074 Ahmed S. Darwish 2022-11-03  381  	if (base < 0)
> 022573e1aaf074 Ahmed S. Darwish 2022-11-03  382  		return 0;
>
> msi_unlock_descs();?

Indeed.