From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_PASS,SPF_SOFTFAIL,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43BE7C433EF for ; Mon, 9 May 2022 18:11:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240059AbiEISPa (ORCPT ); Mon, 9 May 2022 14:15:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240034AbiEISP3 (ORCPT ); Mon, 9 May 2022 14:15:29 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34A661DA74; Mon, 9 May 2022 11:11:34 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: krisman) with ESMTPSA id 25CCB1F43FBD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652119882; bh=MbPPprIzKvxmhduX4Hn0tkmwmTra/9U7Mk0pwr6WmI8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=HyIWaVM8jvUSedn2yuZZVY27tqvcE3NVSCaa1N2QDtZFqmI9ptONPMvD3kbpJ/TP6 6kv/sRrcWZcdgOPl7YeYdbQ0XZTAyfXswqhh1QF1tIbhfSvdw8jCB1hiQqLr301gf2 mP280UWL5V24h/FLNb3ahwsTE4OfxVwAN28qOySm18x3IMOqGr2IWDKUR9h+LsDPw0 pK6AgaTe4JzUxf4Chu90loNUrkWjeWEquvsurdO7wdBHCiOQe5nnH02ylm0BFyXygQ 7qQVjoWK7znnY8z3Upwj8Pfl30U9voKmuEEm/OsR5+feSGFIyyDT5qeDjl7SAoHzHP vieHl9nu9681w== From: Gabriel Krisman Bertazi To: Randy Dunlap Cc: Ming Lei , Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, io-uring@vger.kernel.org, ZiyangZhang , Xiaoguang Wang Subject: Re: [RFC PATCH] ubd: add io_uring based userspace block driver Organization: Collabora References: <20220509092312.254354-1-ming.lei@redhat.com> <8e3ecd00-1c73-7481-fec2-158528b2798f@infradead.org> Date: Mon, 09 May 2022 14:11:19 -0400 In-Reply-To: <8e3ecd00-1c73-7481-fec2-158528b2798f@infradead.org> (Randy Dunlap's message of "Mon, 9 May 2022 09:00:37 -0700") Message-ID: <87bkw6lgoo.fsf@collabora.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org Randy Dunlap writes: > On 5/9/22 02:23, Ming Lei wrote: >> diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig >> index fdb81f2794cd..3893ccd82e8a 100644 >> --- a/drivers/block/Kconfig >> +++ b/drivers/block/Kconfig >> @@ -408,6 +408,13 @@ config BLK_DEV_RBD >> >> If unsure, say N. >> >> +config BLK_DEV_USER_BLK_DRV >> + bool "Userspace block driver" >> + select IO_URING >> + default y > > Any "default y" driver is highly questionable and needs to be justified. > > Also: why is it bool instead of tristate? I think it's only bool because it depends on task_work_add, which is not exported to modules. It is something to be fixed for sure, can that function just be exported? -- Gabriel Krisman Bertazi