Re: [ammarfaizi2-block:google/android/kernel/common/android12-5.10-2022-03 199/9999] arch/arm64/kvm/perf.c:58:36: error: implicit declaration of function 'perf_num_counters'

[Marc Zyngier <maz@kernel.org>]

Hi Ammar,

On Sat, 02 Apr 2022 10:52:39 +0100,
Ammar Faizi <ammarfaizi2@gnuweeb.org> wrote:
> 
> Hi Marc,
> 
> On 4/2/22 4:38 PM, Marc Zyngier wrote:
> > Hi Robot,
> > 
> > On Sat, 02 Apr 2022 04:47:04 +0100,
> > kernel test robot <lkp@intel.com> wrote:
> >> 
> >> Hi Marc,
> >> 
> >> FYI, the error/warning still remains.
> >> 
> >> tree:   https://github.com/ammarfaizi2/linux-block google/android/kernel/common/android12-5.10-2022-03
> > 
> > Oh look, a random Android tree based on ... 5.10.
> > 
> >> head:   64099431c232d4a95f621411747a3972cc1c8061
> >> commit: 13dbdc0759fd4b89417f64d399ffa6a86fdc7caf [199/9999] FROMGIT: KVM: arm64: Turn kvm_arm_support_pmu_v3() into a static key
> >> config: arm64-randconfig-r024-20220331 (https://download.01.org/0day-ci/archive/20220402/202204021112.ErKMELRr-lkp@intel.com/config)
> >> compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project cc2e2b80a1f36a28fa7c96c38c2674b10868f09f)
> >> reproduce (this is a W=1 build):
> >>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >>          chmod +x ~/bin/make.cross
> >>          # install arm64 cross compiling tool for clang build
> >>          # apt-get install binutils-aarch64-linux-gnu
> >>          # https://github.com/ammarfaizi2/linux-block/commit/13dbdc0759fd4b89417f64d399ffa6a86fdc7caf
> >>          git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
> >>          git fetch --no-tags ammarfaizi2-block google/android/kernel/common/android12-5.10-2022-03
> >>          git checkout 13dbdc0759fd4b89417f64d399ffa6a86fdc7caf
> >>          # save the config file to linux build tree
> >>          mkdir build_dir
> >>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash arch/arm64/
> >> 
> >> If you fix the issue, kindly add following tag as appropriate
> >> Reported-by: kernel test robot <lkp@intel.com>
> >> 
> >> All errors (new ones prefixed by >>):
> >> 
> >>>> arch/arm64/kvm/perf.c:58:36: error: implicit declaration of function 'perf_num_counters' [-Werror,-Wimplicit-function-declaration]
> >>             if (IS_ENABLED(CONFIG_ARM_PMU) && perf_num_counters() > 0)
> >>                                               ^
> >>     1 error generated.
> > 
> > $ ls -l arch/arm64/kvm/perf.c
> > ls: cannot access 'arch/arm64/kvm/perf.c': No such file or directory
> > 
> > What is the point of testing trees that have no resemblance with
> > upstream?
> 
> It's my tree. Didn't realize it yields many irrelevant errors like this.
> I will stop pushing Android stuff to this tree.
> 
> Sorry for bothering you.

It doesn't bother me at all, and you shouldn't stop pushing stuff that
is useful to you. My objection is to the testing of random trees and
spamming of random people, specially when it is pretty obvious that
the tree isn't targeting upstream Linux.

You really shouldn't change anything in your workflow on my account.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.