public inbox for gwml@vger.gnuweeb.org
 help / color / mirror / Atom feed
From: Nam Cao <namcao@linutronix.de>
To: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Lukas Wunner <lukas@wunner.de>,
	Bjorn Helgaas <helgaas@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Linux PCI Mailing List <linux-pci@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Rob Herring <robh@kernel.org>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Manivannan Sadhasivam <mani@kernel.org>,
	Krzysztof Wilczynski <kwilczynski@kernel.org>,
	Armando Budianto <sprite@gnuweeb.org>,
	Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
	gwml@vger.gnuweeb.org, namcaov@gmail.com
Subject: Re: [GIT PULL v2] PCI changes for v6.17
Date: Sat, 09 Aug 2025 18:28:07 +0200	[thread overview]
Message-ID: <87tt2gh33c.fsf@yellow.woof> (raw)
In-Reply-To: <aJdxVy1i3wGTvU3b@linux.gnuweeb.org>

Ammar Faizi <ammarfaizi2@gnuweeb.org> writes:

> On Sat, Aug 09, 2025 at 05:32:16PM +0200, Nam Cao wrote:
>> So unlike what VMD doc says, it actually can have non-MSI-X children devices!
>
> If that's the conclusion, then Intel VMD doc also needs fixing :/

Other possibilities are problem with your BIOS (likely), or problem with
Linux's PCI enumeration (unlikely).

But without hardware, I cannot investigate this further. Now that we
know my commit didn't make the driver any worse, I am done here.

>> Please discard the reverts and the diff I sent you, and try the diff
>> below. I believe your machine will work now.
>
> Yes, I can confirm it's now clean. Just to verify both sides, here is
> the last result:
>
>   https://gist.github.com/ammarfaizi2/72578d2b4cc385fbdb5faee69013d530
>
> If that one fix is final, then:
>
> Tested-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
>
> Thanks for the debugging work.

Thanks for running tests, it would be impossible to figure out otherwise.

> It's probably too late to get the fix in mainline before rc1. But if it
> can go upstream sooner, that would be great.

I don't think PCI maintainers are available at the moment, so I will
send the patch next Monday. Time to enjoy my weekends..

Nam

      reply	other threads:[~2025-08-09 16:28 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20250801142254.GA3496192@bhelgaas>
     [not found] ` <175408424863.4088284.13236765550439476565.pr-tracker-bot@kernel.org>
2025-08-07  3:34   ` [GIT PULL v2] PCI changes for v6.17 Ammar Faizi
2025-08-07  3:51     ` Lukas Wunner
2025-08-07  4:44       ` Nam Cao
2025-08-07  4:54       ` Ammar Faizi
2025-08-07  5:03         ` Nam Cao
2025-08-07  5:13           ` Ammar Faizi
2025-08-08 10:59             ` Ammar Faizi
2025-08-08 11:19               ` Ammar Faizi
2025-08-08 13:34                 ` Ammar Faizi
2025-08-08 18:07                 ` Nam Cao
2025-08-08 22:52                   ` Ammar Faizi
2025-08-09  4:34                     ` Nam Cao
2025-08-09 13:28                       ` Ammar Faizi
2025-08-09 14:49                         ` Nam Cao
2025-08-09 15:15                           ` Ammar Faizi
2025-08-09 15:32                             ` Nam Cao
2025-08-09 16:03                               ` Ammar Faizi
2025-08-09 16:28                                 ` Nam Cao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tt2gh33c.fsf@yellow.woof \
    --to=namcao@linutronix.de \
    --cc=alviro.iskandar@gnuweeb.org \
    --cc=ammarfaizi2@gnuweeb.org \
    --cc=gwml@vger.gnuweeb.org \
    --cc=helgaas@kernel.org \
    --cc=kwilczynski@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=lukas@wunner.de \
    --cc=mani@kernel.org \
    --cc=namcaov@gmail.com \
    --cc=robh@kernel.org \
    --cc=sprite@gnuweeb.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox