From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server-vie001.gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE,SPF_PASS, URIBL_DBL_BLOCKED_OPENDNS,URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=3.4.6 Authentication-Results: server-vie001.gnuweeb.org; dkim=pass (2048-bit key; secure) header.d=linutronix.de header.i=@linutronix.de header.a=rsa-sha256 header.s=2020 header.b=MJ8yVLVn; dkim=pass header.d=linutronix.de header.i=@linutronix.de header.a=ed25519-sha256 header.s=2020e header.b=nNgYSaqF; dkim-atps=neutral Received: by server-vie001.gnuweeb.org (Postfix, from userid 1000) id 8B7CB3127B1E; Sat, 9 Aug 2025 16:28:09 +0000 (UTC) Authentication-Results: server-vie001.gnuweeb.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=193.142.43.55; helo=galois.linutronix.de; envelope-from=namcao@linutronix.de; receiver= Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by server-vie001.gnuweeb.org (Postfix) with ESMTPS id EECB43127B03 for ; Sat, 9 Aug 2025 16:28:08 +0000 (UTC) From: Nam Cao DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1754756888; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PS8l+qmFFn8A9kMqskYImlOYBznIbxngq+KJri3fzOU=; b=MJ8yVLVnY1FgjOe1jbGV1gmPUtThCHydpX7PK97BsLQcsbexU791MYy7JjPqx1kRj0q0Ku 9NyjDG/tXBD0qnVD622xTlC6GOf37zVugcSgTEGM/3jDkvNiTeC7Goz7O4XhwkRqhfJbqa 48li9fFDMPc4EatsdvpkGAVazzKI/sKcVSeS3HS/3CEDisy5cwXp6As24EK2crsPsxvcO1 Jgt2kH7bssTGC14taPJcpsdmE1RUAcjlwisGJGAmep/GKO3ZTbpNarvtYXowIyHbE73jp7 SfMTS0jqT3IB6fsC0eGITYo9+S99mf1vF4EBycc5FhMZCMAr6AFma1IpARqeBQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1754756888; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PS8l+qmFFn8A9kMqskYImlOYBznIbxngq+KJri3fzOU=; b=nNgYSaqFQ4yFdo8FEYAO9wlgpDnYAfEa1LYrNMB6MiFS1ikPFkTLqg9ytDoNk+4GFlnslc r0Kcbm6rNyBrStBg== To: Ammar Faizi Cc: Thomas Gleixner , Lukas Wunner , Bjorn Helgaas , Linus Torvalds , Linux PCI Mailing List , Linux Kernel Mailing List , Rob Herring , Lorenzo Pieralisi , Manivannan Sadhasivam , Krzysztof Wilczynski , Armando Budianto , Alviro Iskandar Setiawan , gwml@vger.gnuweeb.org, namcaov@gmail.com Subject: Re: [GIT PULL v2] PCI changes for v6.17 In-Reply-To: References: <87ectlr8l4.fsf@yellow.woof> <20250809043409.wLu40x1p@linutronix.de> <20250809144927.eUbR3MXg@linutronix.de> <87wm7ch5of.fsf@yellow.woof> Date: Sat, 09 Aug 2025 18:28:07 +0200 Message-ID: <87tt2gh33c.fsf@yellow.woof> MIME-Version: 1.0 Content-Type: text/plain List-Id: Ammar Faizi writes: > On Sat, Aug 09, 2025 at 05:32:16PM +0200, Nam Cao wrote: >> So unlike what VMD doc says, it actually can have non-MSI-X children devices! > > If that's the conclusion, then Intel VMD doc also needs fixing :/ Other possibilities are problem with your BIOS (likely), or problem with Linux's PCI enumeration (unlikely). But without hardware, I cannot investigate this further. Now that we know my commit didn't make the driver any worse, I am done here. >> Please discard the reverts and the diff I sent you, and try the diff >> below. I believe your machine will work now. > > Yes, I can confirm it's now clean. Just to verify both sides, here is > the last result: > > https://gist.github.com/ammarfaizi2/72578d2b4cc385fbdb5faee69013d530 > > If that one fix is final, then: > > Tested-by: Ammar Faizi > > Thanks for the debugging work. Thanks for running tests, it would be impossible to figure out otherwise. > It's probably too late to get the fix in mainline before rc1. But if it > can go upstream sooner, that would be great. I don't think PCI maintainers are available at the moment, so I will send the patch next Monday. Time to enjoy my weekends.. Nam