From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server-vie001.gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, SPF_PASS,URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=3.4.6 Authentication-Results: server-vie001.gnuweeb.org; dkim=pass (2048-bit key; secure) header.d=linutronix.de header.i=@linutronix.de header.a=rsa-sha256 header.s=2020 header.b=t5tx4/DC; dkim=pass header.d=linutronix.de header.i=@linutronix.de header.a=ed25519-sha256 header.s=2020e header.b=yHa0EYuk; dkim-atps=neutral Received: by server-vie001.gnuweeb.org (Postfix, from userid 1000) id 631AA3127CEC; Sat, 9 Aug 2025 15:32:18 +0000 (UTC) Authentication-Results: server-vie001.gnuweeb.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=193.142.43.55; helo=galois.linutronix.de; envelope-from=namcao@linutronix.de; receiver= Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by server-vie001.gnuweeb.org (Postfix) with ESMTPS id C4E8E3127CDE for ; Sat, 9 Aug 2025 15:32:17 +0000 (UTC) From: Nam Cao DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1754753537; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BZbRABX71KNiM1YZsVSV5L7I+pnm05kQRVz0yjcb9Jc=; b=t5tx4/DCOsGMhdOC+GYxsOc8pGy6NjeC2wnDn/BjYlLNYJevf7hwH90b8GvHvDvxjPxXwz XA3Z7OfwDWFGqCyhHckVT+n4Y3NC4Zdg4xmfdgJ+LkCmOQFYzSb+Z9dAHrq48wiaoLbLyZ UFFrKog4Q/lP8ubEjAdqWD35OfBfixgDIekWy2EzyN5Z67Vb6LCIzvyIBTLxTfub7bCFi2 DhbDlvIBVxN88ozGe0iYXOQ9ot0JvxUSl0FfYlumHTGV2TmfuANGcqQeXmBXEIMXvw+5Qz IMYeCE1iiXnFFVIi++/ts/EZDgIoPaPHbfKRK4YEFnKet7f53dHBe5ofdNFXrQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1754753537; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BZbRABX71KNiM1YZsVSV5L7I+pnm05kQRVz0yjcb9Jc=; b=yHa0EYukbFVUAlOsG4vONfTw5FGbtm4aPI4DvjK9nOeHCG5IDBGQ5Nzvf9ZLLp/TQ9zr1g p4gZpfNcZ7HutKCg== To: Ammar Faizi Cc: Thomas Gleixner , Lukas Wunner , Bjorn Helgaas , Linus Torvalds , Linux PCI Mailing List , Linux Kernel Mailing List , Rob Herring , Lorenzo Pieralisi , Manivannan Sadhasivam , Krzysztof Wilczynski , Armando Budianto , Alviro Iskandar Setiawan , gwml@vger.gnuweeb.org, namcaov@gmail.com Subject: Re: [GIT PULL v2] PCI changes for v6.17 In-Reply-To: References: <20250807050350.FyWHwsig@linutronix.de> <87ectlr8l4.fsf@yellow.woof> <20250809043409.wLu40x1p@linutronix.de> <20250809144927.eUbR3MXg@linutronix.de> Date: Sat, 09 Aug 2025 17:32:16 +0200 Message-ID: <87wm7ch5of.fsf@yellow.woof> MIME-Version: 1.0 Content-Type: text/plain List-Id: Ammar Faizi writes: > Here's the result after reverting those two commits and applied the diff. > > https://gist.github.com/ammarfaizi2/03c7a9c0fec2a11f206931f1b7790709#file-dmesg_pci_debug_002-txt > > Let's see if this one is enough for you to diagnose the problem. Thanks, I think the problem is clear now. The diff I sent you has a mistake, it should be if (pci_msix_vec_count(pci_dev) < 0) not if (!pci_msix_vec_count(pci_dev)) So the log is wrong, it printed "MSI-X, looking good...". It should have printed the other one. But no need to re-run it, the backtrace is enough. MSI-X, looking good... <-------- wrong log CPU: 3 UID: 0 PID: 183 Comm: systemd-udevd Not tainted 6.16.0-afh2-dbg-2025-08-09-gb622ab28bcac #13 PREEMPT(full) 28137b57996795286f6544f071ec852674a057d4 Hardware name: HP HP Laptop 14s-dq2xxx/87FD, BIOS F.21 03/21/2022 Call Trace: dump_stack_lvl vmd_msi_init msi_domain_alloc irq_domain_alloc_irqs_locked __irq_domain_alloc_irqs __msi_domain_alloc_irqs msi_domain_alloc_irqs_all_locked __msi_capability_init __pci_enable_msi_range pci_alloc_irq_vectors_affinity pcie_portdrv_probe So unlike what VMD doc says, it actually can have non-MSI-X children devices! Please discard the reverts and the diff I sent you, and try the diff below. I believe your machine will work now. diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c index b679c7f28f51..1bd5bf4a6097 100644 --- a/drivers/pci/controller/vmd.c +++ b/drivers/pci/controller/vmd.c @@ -306,9 +306,6 @@ static bool vmd_init_dev_msi_info(struct device *dev, struct irq_domain *domain, struct irq_domain *real_parent, struct msi_domain_info *info) { - if (WARN_ON_ONCE(info->bus_token != DOMAIN_BUS_PCI_DEVICE_MSIX)) - return false; - if (!msi_lib_init_dev_msi_info(dev, domain, real_parent, info)) return false;