Re: [PATCH v1 2/2] daemon: telegram: Handle MySQL error

[Ammar Faizi <ammarfaizi2@gnuweeb.org>]

On 10/28/22 11:46 PM, Alviro Iskandar Setiawan wrote:
> Even this part is also problematic, if you hit an error before
> utils.remove_patch(), the patch file won't get removed because
> exception will stop the current execution and throw the exception to
> the previous call stack.
> 
> I hate try and catch style, because it's very easy to miss an error
> like this. I prefer the way C handles error manually via return value
> like:
> 
>          ret = func_call();
>          if (ret < 0)
>                  goto clean_up;
> 
> But that's obviously not the Python style. Python prefers using
> exceptions which make the caller may not be aware of this cleanup
> strategy!

Ditto.

-- 
Ammar Faizi