From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ammarfaizi2@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,NO_DNS_FOR_FROM,
	URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
Received: from [192.168.88.254] (unknown [36.73.79.120])
	by gnuweeb.org (Postfix) with ESMTPSA id D888A7E595;
	Sun, 12 Jun 2022 13:19:48 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=default; t=1655039991;
	bh=Wc/nWNndnFWp62S9h8PNx38cHHu3sDvQMGve1qKWERk=;
	h=Date:From:To:Cc:References:Subject:In-Reply-To:From;
	b=bWI2iy6f/WTsE/ORy/ACJJHV2CLmE0Fab7Nj/srbkAnhJrqmyPcUB+F9xfYfHdfsX
	 65s2zKulZqalCLxg3lRQmdAZH7ojQ6yiGaEvmbXrxKp8W5wGDZcNYKdE19qWdzC96j
	 f6apcJWEzVkXXspJWLWx9sbC2Ds3okgBVgZEk8V62HZytSIRsIxpPmwfMtLfCKHrCU
	 aHdFUpuzYw8dwOpozgg1Jx7RkVm75iVTQZyLXQDbb9EW2jlbP4iaJTgCGsW4Jyel4P
	 BysX7zxTvFrcAAqWZo9dViFxE4QD64zn18OUbI724CqsKIL4lqVA3GkNz0QXuEwGhC
	 bnqrh1FdK2T1Q==
Message-ID: <8a5005fe-9a90-77c0-fabc-320d97eff398@gnuweeb.org>
Date: Sun, 12 Jun 2022 20:19:40 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Content-Language: en-US
From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
To: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
 Fernanda Ma'rouf <fernandafmr2@gmail.com>,
 Akiekano <hello.akiekano@gmail.com>
Cc: GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>,
 Ammar Alifian Fahdan <kerupuksambel.2000@gmail.com>,
 Irvan Malik Azantha <irvanmalik48@gmail.com>, Khoiri <qq.khoiri@gmail.com>,
 Muhammad Irvan Hakim <irvanhakim.dev@gmail.com>
References: <CAOG64qP3rjgbr2h0J9UdWEHE0-oc7XSn_av1JNMQAW=cA-e5Vw@mail.gmail.com>
 <20220612120720.2750101-10-alviro.iskandar@gnuweeb.org>
 <b64a1785-9fd9-db39-b4e8-a5782897a1fd@gnuweeb.org>
Subject: Re: [PATCH buubuu v1 10/10] view: index: Add meta tags for Facebook
 link preview
In-Reply-To: <b64a1785-9fd9-db39-b4e8-a5782897a1fd@gnuweeb.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
List-Id: <gwml.vger.gnuweeb.org>

On 6/12/22 7:29 PM, Ammar Faizi wrote:
> On 6/12/22 7:07 PM, Alviro Iskandar Setiawan wrote:
>> +    <meta property="og:image" content="http://xfn23pnjq7acxtpo7n6s6kgha4f7fozn26nbigqrrifjrjzjy4jrv6qd.onion/assets/bgp.jpg"/>
> 
> This doesn't look right, you shouldn't hard code the domain name.
> 
> Create a variable in the controller, pass it to view, and put the
> domain here. You can use an environment variable for that as well.

Extra side note:
Do not use onion domain for meta tag, it won't be accessible from a
non Tor network scraper. It's not that onion is forbidden. You can
of course use onion for all of these, but only when the client sends:

    "Host: xxxxxxx.onion"

on the HTTP header request. That being said, it indicates the
agreement with the client that: "Oh yeah, we are in the Tor network,
so onion domain is fine for this request.". And obviously it needs a
decision logic from the controller.

-- 
Ammar Faizi