From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,NO_DNS_FOR_FROM, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from [192.168.169.80] (unknown [182.2.39.146]) by gnuweeb.org (Postfix) with ESMTPSA id 93837804D1; Tue, 6 Sep 2022 16:02:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1662480168; bh=k6xxgUofUVVj6MtTcJUsgSHNg95f/0kdvfwLf8oyadE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=n7ovXS2lwTigzashp7gmyBRgfyX11BTAndU06HgQa5b2NEU81FMGd34+V/O1QXW+e vfd/VN4WlU5r+dUShPcn3BPHfk+Q1h0muJo4rpBSTHqIp5duLsOYVjywctyvRyTIx7 F+1rMt1NmW0ldCe8+DMZivjXZeFz4wv6NZrwXs7QInontelVAJ4/r+cfqTXr4nYuO2 4ni3t+GBX8yqlzhx/qcJNXHDUehurxBt3tpLwAuQBxO9LIXjlW8WQY/vZetWkywD1j ieAJt/jRy6ZL5ECU4YljI5h7O0axbbRYXOFRtPA0QQrucS6DtKEWOGZ+t5e2qSgO5o +63Cea/CBgpiw== Message-ID: <96b21e73-ff59-1d1d-8146-aadba17b69c0@gnuweeb.org> Date: Tue, 6 Sep 2022 23:02:44 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [RFC PATCH v1 4/5] [telegram] Remove unecessary files Content-Language: en-US To: Muhammad Rizki Cc: GNU/Weeb Mailing List , Alviro Iskandar Setiawan References: <20220906111929.1657-1-kiizuha@gnuweeb.org> <20220906111929.1657-5-kiizuha@gnuweeb.org> From: Ammar Faizi In-Reply-To: <20220906111929.1657-5-kiizuha@gnuweeb.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: On 9/6/22 6:19 PM, Muhammad Rizki wrote: > Just remove unecessary files because it's already moved to the > plugins/commands You moved them in patch #1, why not delete these files in the first place? > Signed-off-by: Muhammad Rizki > --- > daemon/telegram/packages/plugins/admin.py | 42 ----------- > daemon/telegram/packages/plugins/scrape.py | 86 ---------------------- > 2 files changed, 128 deletions(-) > delete mode 100644 daemon/telegram/packages/plugins/admin.py > delete mode 100644 daemon/telegram/packages/plugins/scrape.py Can't we squash this into the first patch? Or I missed something? -- Ammar Faizi